From owner-freebsd-current@FreeBSD.ORG  Fri Oct 20 20:00:01 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 85A4E16A407
	for <current@freebsd.org>; Fri, 20 Oct 2006 20:00:01 +0000 (UTC)
	(envelope-from brdbrd@gmail.com)
Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8FBDC43D99
	for <current@freebsd.org>; Fri, 20 Oct 2006 19:59:46 +0000 (GMT)
	(envelope-from brdbrd@gmail.com)
Received: by wr-out-0506.google.com with SMTP id i2so273217wra
	for <current@freebsd.org>; Fri, 20 Oct 2006 12:59:46 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
	b=OyEfTD1SJ8GYyL2y7vjvapCwdlrxfB9fnCu2lwZdPsBSifUEIEvZU9Ird34cV7y4OvX1tJmDesH3TboTuCHqSWO0pQzxZELQPpjUwDwXy8imHRfF1/OyeFZ9JCWMcgDXqRVqi9tsElaFQM05HXNPu/KUEIJQy7I/6Llgd0u692A=
Received: by 10.90.90.16 with SMTP id n16mr1370073agb;
	Fri, 20 Oct 2006 12:59:45 -0700 (PDT)
Received: by 10.90.65.6 with HTTP; Fri, 20 Oct 2006 12:59:45 -0700 (PDT)
Message-ID: <35ffa5710610201259g11c534f1g60a9f28143bff65b@mail.gmail.com>
Date: Fri, 20 Oct 2006 13:59:45 -0600
From: "Brad Davis" <brd@FreeBSD.org>
Sender: brdbrd@gmail.com
To: "Ceri Davies" <ceri@submonkey.net>, current@freebsd.org
In-Reply-To: <20061018113518.GF92966@submonkey.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20061018113518.GF92966@submonkey.net>
X-Google-Sender-Auth: 7bd0f1e55c6f0019
Cc: 
Subject: Re: What to do with quotacheck -l2 ?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Oct 2006 20:00:01 -0000

On 10/18/06, Ceri Davies <ceri@submonkey.net> wrote:
> I found a -l option in quotacheck this morning, which has been there
> since revision 1.1 and never documented.  The option controls the
> maximum number of concurrent filesystems that quotacheck will operate
> on during the second pass, and should almost certainly be documented.
>
> The -l option is ignored without -a, and using it without -a should
> result in some kind of warning.  However, this behaviour has been
> unchanged for the entire lifetime of quotacheck in FreeBSD and I'm
> loathe to break anything, so I turn to you to see if this looks OK.

Hi Ceri,

Only comment is this:

+	/* Setting maxrun (-l) makes no sense without the aflag, but

Should that be something like:

/* Setting maxrun (-l) makes no sense without the -a flag, but

I'm not sure what kind of comments should be in the code.. maybe this:

/* Setting maxrun (-l) makes no sense without the aflag (-a), but


Regards,
Brad Davis