From nobody Mon Oct 13 00:30:11 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4clJCS4vHhz6BWfx; Mon, 13 Oct 2025 00:30:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4clJCS18d4z49Dv; Mon, 13 Oct 2025 00:30:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760315412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=H3xSv2VAVvKoZ8rEAg4jeH+LP6+g5Fu5O95dEOYZHDw=; b=Z+Ggk46/9nerdhlH3zNFrk2+iSfD3/U3cjcULSjt5uQHXZEU0yIT1KPAtXvjC5K0G57lVd 827sWg+El5dGE8+km/1r4xspM6VmI+agaIJ0tLJJjIM3TtOQ8vTOXHqwM9SdtJMAlEg1Hy hrqGsNvlZZ22fq23kp7E/ODkvgOtp+QrsRvJDtqopnSMkmtk7yPwfketiP/Fgn7uLiI3sB R67sjutRWbPmwmhIXFqKUkqfynKdqS7JTitedsXGuZ0cgx5WzuLkbDn4EujxRD554QuDSE w8YDHB7emUbZ3cJlZvCBotFY9Eiut43dLUo1S2594X8LG3S4KNb5+SNQoVvPhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760315412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=H3xSv2VAVvKoZ8rEAg4jeH+LP6+g5Fu5O95dEOYZHDw=; b=Pnxn1Ag8hewCoIS56UGMNFnlEBmvBQ/iTuKWuo29nINGcbjjiZiirAplaJWpi2elQor31K oj5JmzD8lzay6k0VW5Kiu2lmDIXJ9Mx6EZ6d+sGxOcswQBCqzfynUu5wGvJNvSggMWOvf7 w9Z2S51uCgR1lJt4hGgYDfj7+SHjIHd0qWFA8Aa5WgaSe4oisD+VFk+tPNIrEyb06A7+I6 ilL5Q8Ua2pTzcZySqZeIytnKf+dKB6pFe+qkps68fEYvyBXzSxef0D8tPY+gBCBP+nJHCI 25QS96lootalq8EXAE3sjvJ792WL5EyxCQoYsi6rial2SZWr0zFkWukracYbcQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760315412; a=rsa-sha256; cv=none; b=APDq3dscdxs8euRmP9QphJH/U0sFsWA6jGlUca8cRx0T3lXaP+ViAQfRz2Oj0JP54N5j+e tAArSP7KkizbOtdX/FldUaSeAJRhFtubfj9Yf7OSO17tytWasHfwgKUrRMO9keIQnvSH39 k6ugkzbZjoCEpSXDEwO3rZUhNEPHTOKRe1ix5FHZclpu5kfUTjfAaN+/iogkSvSxRZ6siY V6TnxY+hp8RhpGwSLZ3prLz1GVX7tqXv8KwBfLfFnKz51bzrmiLBTeUl2mHm9ZCkIiEMsQ TSWr+ZoAjndsiGaDm9JnXz/OLTqdNAmuaCGrhZhENvcAJl65k8cbkW+jpySFeA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4clJCS0VRbzkcC; Mon, 13 Oct 2025 00:30:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59D0UBkj045241; Mon, 13 Oct 2025 00:30:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59D0UBxl045236; Mon, 13 Oct 2025 00:30:11 GMT (envelope-from git) Date: Mon, 13 Oct 2025 00:30:11 GMT Message-Id: <202510130030.59D0UBxl045236@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Konstantin Belousov Subject: git: f4d5c6d65168 - stable/14 - vm_fault: add helper vm_fault_can_cow_rename() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: f4d5c6d65168d3d9b99a2332d854c14b231188e6 Auto-Submitted: auto-generated The branch stable/14 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=f4d5c6d65168d3d9b99a2332d854c14b231188e6 commit f4d5c6d65168d3d9b99a2332d854c14b231188e6 Author: Konstantin Belousov AuthorDate: 2025-07-24 10:47:52 +0000 Commit: Konstantin Belousov CommitDate: 2025-10-13 00:23:45 +0000 vm_fault: add helper vm_fault_can_cow_rename() (cherry picked from commit 3f05bbdbd80f2eefb647e595dc73e80d6186d6a5) --- sys/vm/vm_fault.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/sys/vm/vm_fault.c b/sys/vm/vm_fault.c index 796b4c44b3f9..9ba96ab888d6 100644 --- a/sys/vm/vm_fault.c +++ b/sys/vm/vm_fault.c @@ -991,6 +991,16 @@ vm_fault_relookup(struct faultstate *fs) return (KERN_SUCCESS); } +static bool +vm_fault_can_cow_rename(struct faultstate *fs) +{ + return ( + /* Only one shadow object and no other refs. */ + fs->object->shadow_count == 1 && fs->object->ref_count == 1 && + /* No other ways to look the object up. */ + fs->object->handle == NULL && (fs->object->flags & OBJ_ANON) != 0); +} + static void vm_fault_cow(struct faultstate *fs) { @@ -1008,15 +1018,7 @@ vm_fault_cow(struct faultstate *fs) * object so that it will go out to swap when needed. */ is_first_object_locked = false; - if ( - /* - * Only one shadow object and no other refs. - */ - fs->object->shadow_count == 1 && fs->object->ref_count == 1 && - /* - * No other ways to look the object up - */ - fs->object->handle == NULL && (fs->object->flags & OBJ_ANON) != 0 && + if (vm_fault_can_cow_rename(fs) && /* * We don't chase down the shadow chain and we can acquire locks. */