From owner-cvs-src@FreeBSD.ORG Wed Apr 5 20:55:28 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 70D5816A400; Wed, 5 Apr 2006 20:55:28 +0000 (UTC) (envelope-from ceri@submonkey.net) Received: from shrike.submonkey.net (cpc2-cdif2-0-0-cust107.cdif.cable.ntl.com [81.104.168.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id C1F9443D49; Wed, 5 Apr 2006 20:55:27 +0000 (GMT) (envelope-from ceri@submonkey.net) Received: from ceri by shrike.submonkey.net with local (Exim 4.60 (FreeBSD)) (envelope-from ) id 1FRF2D-000Oef-UD; Wed, 05 Apr 2006 21:55:25 +0100 Date: Wed, 5 Apr 2006 21:55:25 +0100 From: Ceri Davies To: Pawel Worach Message-ID: <20060405205525.GA16344@submonkey.net> Mail-Followup-To: Ceri Davies , Pawel Worach , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200604032036.k33Kab4L050169@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EuxKj2iCbKjpUGkD" Content-Disposition: inline In-Reply-To: X-PGP: finger ceri@FreeBSD.org User-Agent: Mutt/1.5.11 Sender: Ceri Davies Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/find find.1 find.h function.c option.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2006 20:55:28 -0000 --EuxKj2iCbKjpUGkD Content-Type: multipart/mixed; boundary="vtzGhvizbBRQ85DL" Content-Disposition: inline --vtzGhvizbBRQ85DL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 05, 2006 at 09:55:49AM +0200, Pawel Worach wrote: > On 4/3/06, Ceri Davies wrote: > > ceri 2006-04-03 20:36:37 UTC > > > > FreeBSD src repository > > > > Modified files: > > usr.bin/find find.1 find.h function.c option.c > > Log: > > Add -Btime, -Bnewer, -Bmin, -newerB[Bacmt], -newer[acmt]B options to > > work with the st_birthtime field of struct stat. > > >=20 > After this change the -a (and) operation fails with. > # find . -mtime 1d -a -mtime 2d > find: -a: unknown option >=20 > This seems to be used by some ports, www/apache20 is one of them. Interesting, it's not documented - I wonder if that is by design. Anyway, looks like some others were broken too - I am a dumbass. The fix is attached, I'll commit it ASAP. Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --vtzGhvizbBRQ85DL Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="lexical_dumbass.diff" ? find ? find.1.gz ? getdate.c Index: option.c =================================================================== RCS file: /home/ncvs/src/usr.bin/find/option.c,v retrieving revision 1.24 diff -u -r1.24 option.c --- option.c 3 Apr 2006 20:36:37 -0000 1.24 +++ option.c 5 Apr 2006 20:52:32 -0000 @@ -62,15 +62,15 @@ { "!", c_simple, f_not, 0 }, { "(", c_simple, f_openparen, 0 }, { ")", c_simple, f_closeparen, 0 }, + { "-Bmin", c_Xmin, f_Xmin, F_TIME_B }, + { "-Bnewer", c_newer, f_newer, F_TIME_B }, + { "-Btime", c_Xtime, f_Xtime, F_TIME_B }, { "-a", c_and, NULL, 0 }, { "-acl", c_acl, f_acl, 0 }, { "-amin", c_Xmin, f_Xmin, F_TIME_A }, { "-and", c_and, NULL, 0 }, { "-anewer", c_newer, f_newer, F_TIME_A }, { "-atime", c_Xtime, f_Xtime, F_TIME_A }, - { "-Bmin", c_Xmin, f_Xmin, F_TIME_B }, - { "-Bnewer", c_newer, f_newer, F_TIME_B }, - { "-Btime", c_Xtime, f_Xtime, F_TIME_B }, { "-cmin", c_Xmin, f_Xmin, F_TIME_C }, { "-cnewer", c_newer, f_newer, F_TIME_C }, { "-ctime", c_Xtime, f_Xtime, F_TIME_C }, @@ -97,23 +97,23 @@ { "-mtime", c_Xtime, f_Xtime, 0 }, { "-name", c_name, f_name, 0 }, { "-newer", c_newer, f_newer, 0 }, - { "-neweraa", c_newer, f_newer, F_TIME_A | F_TIME2_A }, - { "-neweraB", c_newer, f_newer, F_TIME_A | F_TIME2_B }, - { "-newerac", c_newer, f_newer, F_TIME_A | F_TIME2_C }, - { "-neweram", c_newer, f_newer, F_TIME_A }, - { "-newerat", c_newer, f_newer, F_TIME_A | F_TIME2_T }, - { "-newerBa", c_newer, f_newer, F_TIME_B | F_TIME2_A }, { "-newerBB", c_newer, f_newer, F_TIME_B | F_TIME2_B }, + { "-newerBa", c_newer, f_newer, F_TIME_B | F_TIME2_A }, { "-newerBc", c_newer, f_newer, F_TIME_B | F_TIME2_C }, { "-newerBm", c_newer, f_newer, F_TIME_B }, { "-newerBt", c_newer, f_newer, F_TIME_B | F_TIME2_T }, - { "-newerca", c_newer, f_newer, F_TIME_C | F_TIME2_A }, + { "-neweraB", c_newer, f_newer, F_TIME_A | F_TIME2_B }, + { "-neweraa", c_newer, f_newer, F_TIME_A | F_TIME2_A }, + { "-newerac", c_newer, f_newer, F_TIME_A | F_TIME2_C }, + { "-neweram", c_newer, f_newer, F_TIME_A }, + { "-newerat", c_newer, f_newer, F_TIME_A | F_TIME2_T }, { "-newercB", c_newer, f_newer, F_TIME_C | F_TIME2_B }, + { "-newerca", c_newer, f_newer, F_TIME_C | F_TIME2_A }, { "-newercc", c_newer, f_newer, F_TIME_C | F_TIME2_C }, { "-newercm", c_newer, f_newer, F_TIME_C }, { "-newerct", c_newer, f_newer, F_TIME_C | F_TIME2_T }, - { "-newerma", c_newer, f_newer, F_TIME2_A }, { "-newermB", c_newer, f_newer, F_TIME2_B }, + { "-newerma", c_newer, f_newer, F_TIME2_A }, { "-newermc", c_newer, f_newer, F_TIME2_C }, { "-newermm", c_newer, f_newer, 0 }, { "-newermt", c_newer, f_newer, F_TIME2_T }, --vtzGhvizbBRQ85DL-- --EuxKj2iCbKjpUGkD Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFENC69ocfcwTS3JF8RAoTjAJ0aL2s1WaJiI9YTQvINf492mZA03QCeNodt P092nfRO668wN3JGV3kEVX8= =TUGZ -----END PGP SIGNATURE----- --EuxKj2iCbKjpUGkD--