From owner-freebsd-embedded@freebsd.org Fri Apr 1 21:12:12 2016 Return-Path: Delivered-To: freebsd-embedded@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A931AB009FB for ; Fri, 1 Apr 2016 21:12:12 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 873431FF4 for ; Fri, 1 Apr 2016 21:12:12 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 86806B009FA; Fri, 1 Apr 2016 21:12:12 +0000 (UTC) Delivered-To: embedded@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 86183B009F9 for ; Fri, 1 Apr 2016 21:12:12 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x22b.google.com (mail-ig0-x22b.google.com [IPv6:2607:f8b0:4001:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B8E61FE6; Fri, 1 Apr 2016 21:12:09 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-ig0-x22b.google.com with SMTP id l20so3746279igf.0; Fri, 01 Apr 2016 14:12:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=toz+6fhfLru2ToC4twZiWx4sJyir6CtnsIoDj3zvr9c=; b=RAUaRzexqJT+RiVsCGvgt6kfWjb98GN+bEkL0YcMORdJVP14/l7Lh5DER0K0mO7c4Y x5rm/syxdoevLbjnYkwXpayKao8vYDwTKKH2T08DrsycMBVnNJc1giGpVQ1FhsUhuGWP GEJ5YiMrdM6gg/RbFxY8N9m+kkOeyqF6sytNFrj2XZ9TleSE8hLbapVbRmKPNSv6F++C y8rV1RNcUM1yOUWg+1IHRD0er6EPzaECI9TH5WPe2FTHSYoHn2xnH+fCgtw+eyVLq88M ziKLf1YIpH4GjrWizi3wBThw4FarIRfa8iKGNGFt+5q8KrMDXW/IGUFXRYZ9QYgWdYHN DBOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=toz+6fhfLru2ToC4twZiWx4sJyir6CtnsIoDj3zvr9c=; b=bcOEimGX5h8QyS1ba8XGn6ntx8DKDKdGf+zhg3GnlHA/Hh+n0+Gv6sjELkR0h2+srr wWWlJwpBhfwBDim/eKFPmnfMCnxI8wuUAfsyxSxSisUZAS6mVKVv4eBEjQidQPPdc2hY EsRDD7xt7tLQBOdAEvo8Ss1P+HVR7ei6JgCryzEQmGa0bY1C1zmcLSQ0KrI0s2vm36h4 P2zSJKOP76tQCT0oNZOqnlSpaZopHRiRNIiAhIlVNEv/Jm6qj0i7quVjmf6WJgNZpHqF lvj34mjjVJPU+ZH+UzzEpwjwpY/fL7oS8xahOzIdMAIavyABe8QcUkevb8rbRodJKMdA lwmQ== X-Gm-Message-State: AD7BkJIoF+HZvZYsUKHWBm7FVjLAQ8hDgKyQyzp1mqKp+3syGd4ehW5m1Wmdt/ukIVFbjXlTmOfBVMKGGq5/HA== MIME-Version: 1.0 X-Received: by 10.50.43.134 with SMTP id w6mr938717igl.22.1459545128579; Fri, 01 Apr 2016 14:12:08 -0700 (PDT) Received: by 10.36.14.19 with HTTP; Fri, 1 Apr 2016 14:12:08 -0700 (PDT) In-Reply-To: References: <20150817160423.GB3078@gmail.com> Date: Fri, 1 Apr 2016 14:12:08 -0700 Message-ID: Subject: Re: spigen(4) SPI Generic IO interface -- need comments From: Adrian Chadd To: Brian Fundakowski Feldman Cc: Warner Losh , Luiz Otavio O Souza , "freebsd-embedded@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2016 21:12:12 -0000 hihi! ok, I'd now like to resurrect this - I'll take a look and see what's missing before we throw it into the tree. I'd like to use this for the atheros MIPS SPI stuff so i can more efficiently speak to an LCD. :P Thanks! -adrian On 22 August 2015 at 17:27, Brian Fundakowski Feldman wrote: > You know, now you're making me wonder if the edge behavior shouldn't also be > configurable per-spigen/per-transfer. Chip select polarity seems far too > dangerous to expose that way. The only SPI device I have lying around so far > is an MCP3008. > > > On Sat, Aug 22, 2015, 8:17 PM Warner Losh wrote: >> >> I've worked on one set of flash that had simple commands for identifying >> it, which were clocked at one rate (slow, to be compatible with older >> members of the family), and other commands that were data transfer that were >> clocked faster to match the data coming from internal pipelines in the part. >> I don't know how common this arrangement is in the wild, though. >> >> And all of this is from memory of something I worked on maybe 10 years ago >> now, so I'm not sure how relevant it is today. I do know NAND flash chips >> have similar behavior, but those don't have a SPI bus. >> >> Warner >> >> >> On Sat, Aug 22, 2015 at 6:09 PM, Brian Fundakowski Feldman >> wrote: >>> >>> That's something I want feedback on: are there scenarios where you want >>> to >>> regularly vary the clock to a specific SPI device, as opposed to varying >>> it >>> among several? It would be easy to add to the transfer ioctls if you have >>> a >>> use case (for example, manual chip select control with more devices than >>> chip select pins in your low-level SPI implementation.) Certainly from a >>> runtime cost perspective it would be no burden. >>> >>> Thanks for taking a look! >>> -- >>> green >>> >>> On Sat, Aug 22, 2015, 5:55 PM Adrian Chadd >>> wrote: >>> >>> > Hi! >>> > >>> > This looks cool! Is there any reason why the clock isn't per >>> > transaction? >>> > >>> > >>> > -a >>> > >>> > >>> > On 22 August 2015 at 11:23, Brian Fundakowski Feldman >>> > wrote: >>> > > I've added a couple more features: >>> > > * clock adjustment via ioctl, independent per spigenN device >>> > > * mmap(2) support for very low latency >>> > > >>> > > On Tue, Aug 18, 2015 at 6:47 PM, Brian Fundakowski Feldman < >>> > > brianfundakowskifeldman@gmail.com> wrote: >>> > > >>> > >> On Mon, Aug 17, 2015 at 12:04 PM Tom Jones wrote: >>> > >> >>> > >>> On Mon, Aug 17, 2015 at 10:00:26AM -0400, Brian Fundakowski Feldman >>> > wrote: >>> > >>> > I'm woefully out-of-practice with my kernel hackery (but still >>> > >>> > pretty >>> > >>> > proficient in jiggery-pokery) so I would like to get comments on >>> > >>> > a >>> > >>> little >>> > >>> > driver I just made for interfacing arbitrarily in userland with >>> > >>> > SPI >>> > >>> > components. The only thing I'm exposing is a /dev/spigenN node >>> > >>> > with >>> > a >>> > >>> > single transfer ioctl and I put together a test circuit and >>> > >>> > program >>> > >>> with an >>> > >>> > MCP3008 10-bit ADC IC to validate that it basically works, other >>> > >>> > than >>> > >>> the >>> > >>> > limitation that the transfers must be octet-multiply-sized, but I >>> > >>> haven't >>> > >>> > looked at the SoC's (I'm using a Raspberry Pi 2) data sheet to >>> > >>> > tell >>> > >>> whether >>> > >>> > that's just a limit on the spibus(4) interface or the Broadcom >>> > >>> > SPI >>> > >>> driver >>> > >>> > or the Broadcom SoC itself. >>> > >>> > >>> > >>> > I hit one snag in development where I simply called the ioctl >>> > >>> > wrong >>> > and >>> > >>> > found copyin(9) to page fault HARD if given a bogus user address >>> > >>> > to >>> > copy >>> > >>> > from, and panic the kernel. I can post up the test program if >>> > >>> > anyone >>> > >>> wants >>> > >>> > but it's very trivial: I just align the start bit and the command >>> > data >>> > >>> into >>> > >>> > the least significant bits of the first octet, shift it up two >>> > >>> positions so >>> > >>> > the NULs get clocked out as part of the command field, and >>> > >>> > provide >>> > two >>> > >>> > octets for the data field to retrieve back the 10-bit digital >>> > >>> > value. >>> > >>> >>> > >>> Oh, cool. >>> > >>> >>> > >>> I did the same earlier this year, have you seen[1]?. >>> > >>> >>> > >>> The FreeBSD i2c api is the same/very similar the linux one[2][3]. >>> > >>> Have >>> > you >>> > >>> considered adding some of the ioctls[3] or the data structures to >>> > >>> make >>> > it >>> > >>> easier to port code? >>> > >>> >>> > >>> [1]: >>> > >>> >>> > >>> > https://lists.freebsd.org/pipermail/freebsd-embedded/2015-April/002466.html >>> > >>> [2]: https://www.kernel.org/doc/Documentation/i2c/dev-interface >>> > >>> [3]: >>> > >>> >>> > >>> > https://www.freebsd.org/cgi/man.cgi?query=iic&apropos=0&sektion=0&manpath=FreeBSD+10.2-RELEASE&arch=default&format=html >>> > >>> [4]: https://www.kernel.org/doc/Documentation/spi/spidev >>> > >> >>> > >> >>> > >> I've iterated a bit on this to try to make some more sensible API, >>> > >> behaving reasonably about being able to set the SPI clock speed. >>> > >> I'm >>> > going >>> > >> to implement an mmap handler so I can have my low-latency operation >>> > mode, >>> > >> as well. I don't like the Linux APIs one bit because it's just not >>> > safe to >>> > >> allow all those configuration changes on a per-transfer basis... >>> > >> >>> > >> Moving this to -embedded because it's more apt than -hackers. >>> > >> >>> > > >>> > > _______________________________________________ >>> > > freebsd-embedded@freebsd.org mailing list >>> > > https://lists.freebsd.org/mailman/listinfo/freebsd-embedded >>> > > To unsubscribe, send any mail to " >>> > freebsd-embedded-unsubscribe@freebsd.org" >>> > >>> _______________________________________________ >>> freebsd-embedded@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-embedded >>> To unsubscribe, send any mail to >>> "freebsd-embedded-unsubscribe@freebsd.org" >> >> >