From owner-freebsd-current  Tue Jul 16 19:22: 1 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C5FB137B400
	for <current@FreeBSD.ORG>; Tue, 16 Jul 2002 19:21:59 -0700 (PDT)
Received: from gehicks.dyndns.org (adsl-35-49-18.asm.bellsouth.net [67.35.49.18])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B32E243E5E
	for <current@FreeBSD.ORG>; Tue, 16 Jul 2002 19:21:58 -0700 (PDT)
	(envelope-from gehicks@gehicks.dyndns.org)
Received: from mac (mac [10.0.0.13])
	by gehicks.dyndns.org (8.12.5/8.12.5) with ESMTP id g6H2TCVH004532;
	Wed, 17 Jul 2002 02:29:17 GMT
	(envelope-from gehicks@gehicks.dyndns.org)
Date: Tue, 16 Jul 2002 22:21:47 -0400
Subject: Re: /usr/src/dev/md  error (?)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Mime-Version: 1.0 (Apple Message framework v482)
Cc: Dikshie <dikshie@ppk.itb.ac.id>, <current@FreeBSD.ORG>
To: Bruce Evans <bde@zeta.org.au>
From: W Gerald Hicks <gehicks@gehicks.dyndns.org>
In-Reply-To: <20020717115641.T3327-100000@gamplex.bde.org>
Message-Id: <F1D80E50-992B-11D6-99DB-0030657B5F1E@gehicks.dyndns.org>
Content-Transfer-Encoding: 7bit
X-Mailer: Apple Mail (2.482)
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG


On Tuesday, July 16, 2002, at 10:13 PM, Bruce Evans wrote:

> On Tue, 16 Jul 2002, W Gerald Hicks wrote:
>
>> Following patch should silence it.
>> ...
>> Index: src/sys/dev/md/md.c
>> ===================================================================
>> RCS file: /home/ncvs/src/sys/dev/md/md.c,v
>> retrieving revision 1.66
>> diff -u -r1.66 md.c
>> --- src/sys/dev/md/md.c 24 Jun 2002 12:07:02 -0000      1.66
>> +++ src/sys/dev/md/md.c 16 Jul 2002 21:32:44 -0000
>> @@ -606,6 +606,7 @@
>>                          error = mdstart_swap(sc, bp);
>>                          break;
>>                  default:
>> +                       error = -1;
>>                          panic("Impossible md(type)");
>>                          break;
>>                  }
>
> This change and the break after the panic() are bogus.  panic() "never"
> returns, and the compiler knows this.  Unfortunately, the 
> RESTARTABLE_PANICS
> option subverts the semantics of panic(), so panic() sometimes returns.
> This breaks compilation of md.c and 28 other files in NOTES.  The fix
> shouldn't be to disturb the usual flow of control in those 29 files.
>
> Bruce
>

Ouch.  My naive assumption was that panic() really did the deed.

Agree,  my suggestion is bogus.

Thanks,

Jerry Hicks


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message