From owner-freebsd-hackers  Wed Apr  3 23: 6:21 2002
Delivered-To: freebsd-hackers@freebsd.org
Received: from falcon.prod.itd.earthlink.net (falcon.mail.pas.earthlink.net [207.217.120.74])
	by hub.freebsd.org (Postfix) with ESMTP id 0419237B416
	for <hackers@freebsd.org>; Wed,  3 Apr 2002 23:06:14 -0800 (PST)
Received: from pool0193.cvx40-bradley.dialup.earthlink.net ([216.244.42.193] helo=mindspring.com)
	by falcon.prod.itd.earthlink.net with esmtp (Exim 3.33 #1)
	id 16t1Jt-0003mp-00; Wed, 03 Apr 2002 23:06:05 -0800
Message-ID: <3CABFB3C.E2E40D7B@mindspring.com>
Date: Wed, 03 Apr 2002 23:05:32 -0800
From: Terry Lambert <tlambert2@mindspring.com>
X-Mailer: Mozilla 4.7 [en]C-CCK-MCD {Sony}  (Win98; U)
X-Accept-Language: en
MIME-Version: 1.0
To: Peter Wemm <peter@wemm.org>
Cc: David Greenman <dg@root.com>, Will Froning <wfroning@angui.sh>,
	hackers@FreeBSD.ORG
Subject: Re: Fatal trap 12: page fault while in kernel mode
References: <20020404055149.CE6263811@overcee.wemm.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG

Peter Wemm wrote:
> > You will need to modify nfs_realign() to take a waitflag,
                     +++++++++++++++++++++++++++++++++++++++
> > as propagated from nfsrv_rcv()... and then pass it through
       *************************

> Terry, if you spent half of the time reading the code as speculating and
> writing about your wild speculation, you'd know that we already have a
> "waitflag" for nfsrv_rcv() to track safeness to wait or not.

If you had read the above, you'd see I knew that.  Note the
asterisk marked phrase.

> The bug is that
> nfs_realign doesn't take the 'waitflag' argument and has two 'can wait'
> mbuf allocation calls.

I said that, too.  Note the plus sign marked phrase.  8-).

> The fix is trivial and hardly ugly.  But then again, anybody who actually
> bothered to read the code before posting would know that.

It was a general comment on the NFS code.

You suggested exactly the same fix I did...

-- Terry

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message