From owner-freebsd-net@freebsd.org Mon Feb 27 16:00:33 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AA584CF0FE6 for ; Mon, 27 Feb 2017 16:00:33 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 913CBF2C for ; Mon, 27 Feb 2017 16:00:33 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from Julian-MBP3.local (ppp121-45-246-6.lns20.per4.internode.on.net [121.45.246.6]) (authenticated bits=0) by vps1.elischer.org (8.15.2/8.15.2) with ESMTPSA id v1RG0Rrk008984 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 27 Feb 2017 08:00:31 -0800 (PST) (envelope-from julian@freebsd.org) Subject: Re: NETGRAPH's ng_cisco and IPv6 support To: =?UTF-8?B?xYF1a2FzeiBXw7NqY2lr?= , freebsd-net@freebsd.org References: <9980efee-f51c-2e48-59e1-099a609fc0a3@zoho.com> From: Julian Elischer Message-ID: Date: Tue, 28 Feb 2017 00:00:22 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <9980efee-f51c-2e48-59e1-099a609fc0a3@zoho.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 16:00:33 -0000 On 24/2/17 3:03 am, Łukasz Wójcik wrote: > Hello everyone, > > I've recently started to develop certain driver that uses 'ng_cisco' > netgraph module for CHDLC en-/de-capsulation. > When it connects with ng_cisco node via 'inet' hook, everything > works fine, but there is an issue when trying to > use 'inet6' node. cisco_notify() routine only sends flow control > messages to nodes connected via 'inet' hook, > completely ignoring those connected via 'inet6'. This poses some > problem if peer node relies on link status information > passed from ng_cisco. I'd therefore like to suggest/discuss a patch > (attached to this email). All it does is to make ng_cisco node > pass flow control messages to *both* 'inet' and 'inet6' peers. It > seems to me that it is both possible and sensible to > expect both mentioned hooks to be connected at the same time. > > I would appreciate any feedback. ipv6 was still a "some time in the future" thing when I wrote the ng_cisco node (or did archie do that one.?) I'm pretty sire someone who knows IPv6 needs to go through the entire suite with a broom. > > Best regards, > -ŁW > > > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"