Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 9 May 2023 09:38:48 +0000
From:      Gary Jennejohn <garyj@gmx.de>
To:        Corvin =?ISO-8859-1?B?S/ZobmU=?= <corvink@FreeBSD.org>
Cc:        Ed Maste <emaste@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: 76887e84be97 - main - cpuset: increase userland maximum size to 1024
Message-ID:  <20230509113848.5c9529e1@ernst.home>
In-Reply-To: <2f47388ab07eaeb820344e928adb96ff6f7a5916.camel@FreeBSD.org>
References:  <202305081826.348IQm9N040108@gitrepo.freebsd.org> <0dadaa17917629e3399fe9acbab17eb60b63575d.camel@FreeBSD.org> <2f47388ab07eaeb820344e928adb96ff6f7a5916.camel@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 09 May 2023 09:43:27 +0200
Corvin K=F6hne <corvink@FreeBSD.org> wrote:

> On Tue, 2023-05-09 at 08:59 +0200, Corvin K=F6hne wrote:
> > On Mon, 2023-05-08 at 18:26 +0000, Ed Maste wrote:
> > > The branch main has been updated by emaste:
> > >
> > > URL:
> > > https://cgit.FreeBSD.org/src/commit/?id=3D76887e84be975698b14699d7d0=
dfb157d73e9990
> > >
> > > commit 76887e84be975698b14699d7d0dfb157d73e9990
> > > Author:=A0=A0=A0=A0 Ed Maste <emaste@FreeBSD.org>
> > > AuthorDate: 2023-05-02 20:57:12 +0000
> > > Commit:=A0=A0=A0=A0 Ed Maste <emaste@FreeBSD.org>
> > > CommitDate: 2023-05-08 18:25:15 +0000
> > >
> > > =A0=A0=A0 cpuset: increase userland maximum size to 1024
> > > =A0=A0=A0
> > > =A0=A0=A0 Hardware with more than 256 CPU cores is now available and=
 will
> > > become
> > > =A0=A0=A0 increasingly common.=A0 Bump CPU_MAXSIZE (used for userlan=
d
> > > cpuset_t
> > > =A0=A0=A0 sizing) to 1024 to define the ABI for FreeBSD 14.
> > > =A0=A0=A0
> > > =A0=A0=A0 PR:=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 269572, 271213 [ex=
p-run]
> > > =A0=A0=A0 Reviewed by:=A0=A0=A0 mjg, jhb
> > > =A0=A0=A0 Relnotes:=A0=A0=A0=A0=A0=A0 yes
> > > =A0=A0=A0 Sponsored by:=A0=A0 The FreeBSD Foundation
> > > =A0=A0=A0 Differential Revision: https://reviews.freebsd.org/D39941
> > > ---
> > > =A0sys/sys/_cpuset.h | 2 +-
> > > =A01 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/sys/sys/_cpuset.h b/sys/sys/_cpuset.h
> > > index b75ee595da3c..676f9855f384 100644
> > > --- a/sys/sys/_cpuset.h
> > > +++ b/sys/sys/_cpuset.h
> > > @@ -40,7 +40,7 @@
> > > =A0#define=A0=A0=A0=A0=A0=A0=A0=A0CPU_SETSIZE=A0=A0=A0=A0=A0MAXCPU
> > > =A0#endif
> > > =A0
> > > -#define=A0=A0=A0=A0=A0=A0=A0=A0CPU_MAXSIZE=A0=A0=A0=A0=A0256
> > > +#define=A0=A0=A0=A0=A0=A0=A0=A0CPU_MAXSIZE=A0=A0=A0=A0=A01024
> > > =A0
> > > =A0#ifndef=A0=A0=A0=A0=A0=A0=A0=A0CPU_SETSIZE
> > > =A0#define=A0=A0=A0=A0=A0=A0=A0=A0CPU_SETSIZE=A0=A0=A0=A0=A0CPU_MAXS=
IZE
> >
> > Hi Ed,
> >
> > this somehow breaks bhyve on my system. It immediately exits with
> > "vm_run error -1" on startup.
> >
> >
>
> Setting MAXCPU [1] to 1024 as well, solves the issue. Not sure if it's
> a regression of your commit or a bhyve bug.
>
> [1]
> https://github.com/freebsd/freebsd-src/blob/20d8d9809a8c0a3ddd1d0156e77e=
c53a1ed95747/sys/amd64/include/param.h#L68
>

Unfortunately, not a viable solution for users who set MAXCPU in their
kernel configuration file.

=2D-
Gary Jennejohn



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20230509113848.5c9529e1>