From owner-freebsd-current@FreeBSD.ORG Tue Sep 6 12:45:24 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E49E316A41F; Tue, 6 Sep 2005 12:45:24 +0000 (GMT) (envelope-from keramida@freebsd.org) Received: from rosebud.otenet.gr (rosebud.otenet.gr [195.170.0.94]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D3A143D49; Tue, 6 Sep 2005 12:45:23 +0000 (GMT) (envelope-from keramida@freebsd.org) Received: from orion.daedalusnetworks.priv (aris.bedc.ondsl.gr [62.103.39.226]) by rosebud.otenet.gr (8.13.4/8.13.4/Debian-1) with SMTP id j86CjDpT018903; Tue, 6 Sep 2005 15:45:13 +0300 Received: from orion.daedalusnetworks.priv (orion [127.0.0.1]) by orion.daedalusnetworks.priv (8.13.4/8.13.4) with ESMTP id j86CjCJR027454; Tue, 6 Sep 2005 15:45:12 +0300 (EEST) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost) by orion.daedalusnetworks.priv (8.13.4/8.13.4/Submit) id j86Cj9eD027453; Tue, 6 Sep 2005 15:45:09 +0300 (EEST) (envelope-from keramida@freebsd.org) X-Authentication-Warning: orion.daedalusnetworks.priv: keramida set sender to keramida@freebsd.org using -f Date: Tue, 6 Sep 2005 15:45:08 +0300 From: Giorgos Keramidas To: Slawa Olhovchenkov Message-ID: <20050906124508.GA27413@orion.daedalusnetworks.priv> References: <20050903133344.GA633@gothmog.gr> <20050905162713.GA92142@crodrigues.org> <20050905175826.GL69481@zxy.spb.ru> <20050906015418.GA590@gothmog.gr> <20050906120809.GP69481@zxy.spb.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050906120809.GP69481@zxy.spb.ru> Cc: rodrigc@freebsd.org, Craig Rodrigues , freebsd-current@freebsd.org, mirya@matrix.kiev.ua Subject: Re: moused related panic X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Sep 2005 12:45:25 -0000 On 2005-09-06 16:08, Slawa Olhovchenkov wrote: >On Tue, Sep 06, 2005 at 04:54:19AM +0300, Giorgos Keramidas wrote: >>On 2005-09-05 21:58, Slawa Olhovchenkov wrote: >>>On Mon, Sep 05, 2005 at 12:27:13PM -0400, Craig Rodrigues wrote: >>>> On Sat, Sep 03, 2005 at 04:33:44PM +0300, Giorgos Keramidas wrote: >>>> > This was on a console running with 132x25 mode. >>>> >>>> Can you try this? >>> >>> 1. I think your remember '()' around '||' >>> 2. Now mouse cursor not moved. >> >> I think I've found why this seems broken in non-graphics VESA modes. > > I am use non-vesa, non-graphics mode (80x30). I am not use VESA module > and don't have option VESA in the kernel. This is diffirent case? I'm also using a non-graphics mode (132x25) and a custom font too. This is the same case, as far as set_mouse_pos() is concerned, because ISGRAPHSC(scp) is false in this case. I'm not sure if the correct fix is the bug I posted but at least it solved the panics for me. I don't know why scp->font_width == 0 in text modes. Perhaps the bug is elsewhere, i.e. in the font changing code that should update scp->font_width with a non-zero value. I don't really like the "hackish" way my last patch avoids the panics, because assuming that a default font_width of 8 is ok is probably one gratuitous assumption too many. I haven't had a chance to look at the font changing implementation to see if scp->font_width can be set elsewhere to a non-zero value or if it's supposed to be zero in text modes. - Giorgos