From owner-svn-src-head@freebsd.org  Tue Jun  6 13:53:42 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 783DDBD3389;
 Tue,  6 Jun 2017 13:53:42 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (turbocat.net [88.99.82.50])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3FF046A54D;
 Tue,  6 Jun 2017 13:53:41 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from hps2016.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id C9791260873;
 Tue,  6 Jun 2017 15:53:31 +0200 (CEST)
From: Hans Petter Selasky <hps@selasky.org>
Subject: Re: svn commit: r316311 - in head: lib/libstand sys/boot/geli
 sys/boot/i386/gptboot sys/boot/i386/loader sys/boot/i386/zfsboot
To: Allan Jude <allanjude@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201703310004.v2V04W3A043449@repo.freebsd.org>
Message-ID: <85ee6ae1-f934-caf6-a219-3d9901f3d277@selasky.org>
Date: Tue, 6 Jun 2017 15:51:26 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <201703310004.v2V04W3A043449@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Jun 2017 13:53:42 -0000

On 03/31/17 02:04, Allan Jude wrote:
> Author: allanjude
> Date: Fri Mar 31 00:04:32 2017
> New Revision: 316311
> URL: https://svnweb.freebsd.org/changeset/base/316311
> 


> 
> Modified: head/sys/boot/i386/zfsboot/zfsboot.c
> ==============================================================================
> --- head/sys/boot/i386/zfsboot/zfsboot.c	Thu Mar 30 23:49:57 2017	(r316310)
> +++ head/sys/boot/i386/zfsboot/zfsboot.c	Fri Mar 31 00:04:32 2017	(r316311)
> @@ -926,7 +926,7 @@ load(void)
>       zfsargs.primary_pool = primary_spa->spa_guid;
>   #ifdef LOADER_GELI_SUPPORT
>       bcopy(gelipw, zfsargs.gelipw, sizeof(zfsargs.gelipw));
> -    bzero(gelipw, sizeof(gelipw));
> +    explicit_bzero(gelipw, sizeof(gelipw));
>   #else
>       zfsargs.gelipw[0] = '\0';
>   #endif
> 

Hi Allan,

For ARM platforms you'll need to do a write memory barrier before the 
explicit_bzero() returns, else the memory can be recovered by 
invalidating the memory area by the next thread which is allocating this 
memory ???

--HPS