From owner-freebsd-x11@FreeBSD.ORG  Fri Apr 27 17:03:27 2012
Return-Path: <owner-freebsd-x11@FreeBSD.ORG>
Delivered-To: x11@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B5046106566C;
	Fri, 27 Apr 2012 17:03:27 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id CF7B38FC0C;
	Fri, 27 Apr 2012 17:03:26 +0000 (UTC)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id UAA10510;
	Fri, 27 Apr 2012 20:03:15 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Message-ID: <4F9AD153.4000103@FreeBSD.org>
Date: Fri, 27 Apr 2012 20:03:15 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:12.0) Gecko/20120426 Thunderbird/12.0
MIME-Version: 1.0
To: Warren Block <wblock@wonkity.com>, matt <sendtomatt@gmail.com>
References: <4F9541DD.3080200@netfence.it>
	<alpine.BSF.2.00.1204230648560.68901@wonkity.com>
	<4F956713.60604@gmail.com>
	<alpine.BSF.2.00.1204231032020.69711@wonkity.com>
	<4F979BCA.9050800@gmail.com> <4F98F3BC.3020305@gmail.com>
	<alpine.BSF.2.00.1204260912001.20978@wonkity.com>
In-Reply-To: <alpine.BSF.2.00.1204260912001.20978@wonkity.com>
X-Enigmail-Version: 1.4
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: x11@FreeBSD.org, freebsd-ports@FreeBSD.org
Subject: Re: New X.Org
X-BeenThere: freebsd-x11@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: X11 on FreeBSD -- maintaining and support <freebsd-x11.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
	<mailto:freebsd-x11-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-x11>
List-Post: <mailto:freebsd-x11@freebsd.org>
List-Help: <mailto:freebsd-x11-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
	<mailto:freebsd-x11-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 17:03:27 -0000

on 26/04/2012 18:45 Warren Block said the following:
> On Thu, 26 Apr 2012, matt wrote:
> 
>>>>> Interesting. Another Radeon 4650 (rv730) is not working here, giving Bus
>>>>> Errors at the same address whenever certain applications are launched.
>>>>> Failing examples: Firefox, gedit, qt4-designer Successful: xfce4-terminal,
>>>>> ioquake3, compiz
>>>
>> Fixed this issue using the changes indicated in the below patch, which
>> solved my issue with x bus errors. It looks like glxGetScreen was
>> choking. This may help users with similar problems in compiz or Kwin.
>> FYI I manually applied changes in the patch to x11-servers/xorg-server,
>> not sure if the patch below would apply cleanly.
>>
>> diff --git a/glx/glxdri.c b/glx/glxdri.c
>> index 326f539..f6ef784 100644
>> --- a/glx/glxdri.c
>> +++ b/glx/glxdri.c
>> @@ -230,7 +230,7 @@ __glXDRIdrawableDestroy(__GLXdrawable *drawable)
>>
>>     /* If the X window was destroyed, the dri DestroyWindow hook will
>>      * aready have taken care of this, so only call if pDraw isn't NULL. */
>> -    if (drawable->pDraw != NULL) {
>> +    if (drawable->pDraw != NULL && drawable->pDraw->type == DRAWABLE_WINDOW) {
>>     screen = (__GLXDRIscreen *) glxGetScreen(drawable->pDraw->pScreen);
>>     (*screen->core->destroyDrawable)(private->driDrawable);
>>
> 
> Good catch!  Please enter a PR for this!

Just double-check that this change doesn't introduce any memory/resource leaks :-)

-- 
Andriy Gapon