From owner-svn-src-all@freebsd.org Mon Jan 14 21:24:50 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 096541488394; Mon, 14 Jan 2019 21:24:50 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 23F9B76B26; Mon, 14 Jan 2019 21:24:48 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id j9iogw95g82Ycj9ipgxZPp; Mon, 14 Jan 2019 14:24:41 -0700 X-Authority-Analysis: v=2.3 cv=NNSrBHyg c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=IkcTkHD0fZMA:10 a=3JhidrIBZZsA:10 a=iKhvJSA4AAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=lz2pXyTTt24pO-65IhIA:9 a=QEXdDO2ut3YA:10 a=odh9cflL3HIXMm4fY7Wr:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from android-68f84e02b5988183.esitwifi.local (S0106788a207e2972.gv.shawcable.net [70.66.154.233]) by spqr.komquats.com (Postfix) with ESMTPSA id 6524E7A0; Mon, 14 Jan 2019 13:24:46 -0800 (PST) Date: Mon, 14 Jan 2019 13:24:14 -0800 User-Agent: K-9 Mail for Android In-Reply-To: <201901142031.x0EKVQSb036914@pdx.rh.CN85.dnsmgr.net> References: <201901142031.x0EKVQSb036914@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: svn commit: r343011 - in head/kerberos5: lib/libasn1 lib/libgssapi_krb5 lib/libhdb lib/libheimntlm lib/libhx509 lib/libkadm5clnt lib/libkadm5srv lib/libkdc lib/libkrb5 lib/libwind libexec/digest-se... To: rgrimes@freebsd.org,"Rodney W. Grimes" CC: Takahashi Yoshihiro , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Cy Schubert Message-ID: <500EC03A-1DAB-45A6-9CA8-1DE960EB6E6D@cschubert.com> X-CMAE-Envelope: MS4wfLUEWHAgLlC2tiAAZ/tcyTUDT8SUo4OVwKWMhuQaEA7ta2g27Gun98QXr5L0GT4agzDPqYKDO15uwXaMloXU4T1spBi0iO/wFyfT25RSPoN3d0z+HaT0 alP5chacTE2pKbDc2FjwmAzphHjxVsBrsndUVy4ZFOuhqhqrx5cRGVfxN7EjkaZo16J73PCqBi+3GX6Qn5tqazWi5P/q4HHkkfBmTWQXpsvcjWGXtaj9N0T3 crbAfbrlcOobtBmQi3tpO+PMiL+vpRaspFfZr4rPVQkiUTXb1KUYKqfj0/1zNhQkcDVgCQoozVyuLHSi3NmVX5YTfCTZKLREGaTwPwAj+mQxqPpZ3zV4bi07 wdTQTKPx X-Rspamd-Queue-Id: 23F9B76B26 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.972,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 21:24:50 -0000 On January 14, 2019 12:31:26 PM PST, "Rodney W=2E Grimes" wrote: >> In message <201901141617=2Ex0EGHwqQ035748@pdx=2Erh=2ECN85=2Ednsmgr=2Ene= t>,=20 >> "Rodney W=2E Gri >> mes" writes: >> > > Author: nyan >> > > Date: Mon Jan 14 06:34:54 2019 >> > > New Revision: 343011 >> > > URL: https://svnweb=2Efreebsd=2Eorg/changeset/base/343011 >> > >=20 >> > > Log: >> > > Use ${SRCTOP}/contrib/com_err/com_err=2Eh instead of the >installed com_err=2E >> > h=2E >> > > This fixes build when com_err=2Eh is not installed=2E >> > >> > Isn't this the general state of affairs for almost all >> > of the source tree? I would rather see this solved >> > in a general way, rather than sprinkly all this >> > -I${SRCTOP} all over in the tree=2E >>=20 >> Agreed however in practice this is fixed when discovered while >working=20 >> on other issues/problems/projects=2E > >This adds another special case that should not exist=2E > >> > >> > It use to be (and maybe still is) required that you run >> > cd $DRCTOP && make includes >> > if you expected new source code to compile=2E I expect >> > this has changed, but the just of it should work in >> > some aspect=2E >>=20 >> This fixes the potential bug of requiring a header file to be=20 >> installed=2E I suspect this to be an oversight at the time=2E >>=20 >> Good that it's fixed now=2E > >Something is wrong, as infact com_err=2Eh *IS* >installed as /usr/include/com_err=2Eh > >diff /usr/include/com_err=2Eh /usr/src/contrib/com_err/com_err=2Eh This is the typical location krb5 puts this file=2E There is a project bra= nch that moves this file by making kerberos private=2E It's currently block= ed by a number of ports this breaks, most of which are addressed=2E=20 --=20 Pardon the typos and autocorrect, small keyboard in use=2E Cheers, Cy Schubert FreeBSD UNIX: Web: http://www=2EFreeBSD=2Eorg The need of the many outweighs the greed of the few=2E