From nobody Fri Mar 29 20:38:17 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V5sgH6h9Xz5Fh5r; Fri, 29 Mar 2024 20:38:19 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V5sgH5hkJz4Fjr; Fri, 29 Mar 2024 20:38:19 +0000 (UTC) (envelope-from bapt@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711744699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cte94o80a4GQNU1FJtxqbsvEotPlQPShJxIf6TNq4nA=; b=GEk1jTrWC/FktsHR77CuRkxpFK3bc+7mx6Dmeb9MZIgVohHgQUAxkt4KuFF9vgSrS1MAl0 3Hi0kCufYIW6yUiCZ+UJYX2iwICBcGVmJM5vRkRjshGtd+l5iRNI2/XHAqsrW9UJ7W1sec /ZmRqvAtFQeNSq6bN4auAh8fZd0YLC0f/oxRQTErkpy04+53b41Li4GrAwkgZxdzvrzfoK n40AHG4x8xtQNSMtI31CKAONhAzsPTO5/sKlGpP36aeiNvs3zfyEUOpmtTosxiHozalwXo 4htJqXQZCmisLhtLfQYPVDe9S6Fg4CtKw4sRKGCIoVLWbhQAiNku6QZRoKkkFQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711744699; a=rsa-sha256; cv=none; b=fGzo15MD1qNUDKXV5vg8JbFvd3GXtGPtBTZ3PO+4p7YqgjjOkkf2koPu8SQ/apRkB6OUvj xMpsGcnYgQlfh2T+yhqzL81vIj6HuNze1CHj7oyR1KRBs7HNGTk5ZoDirc503Fcj7Et+oZ mQRBiIqUaVD+h/KRvCx8YSKtQ5fN2xtFF4Vziojz1k0jx73lqk5UeYzPiThGkddyBOfzzF 03MfadAyAUx0MTHW/k2360twHCuRsrNoTzP0mUU8NEAkxW1jFRPcUisbyAnboY+pXAS4zB VkZYTBgHuKfs5s7Mc1/FpP3Pf3U3WzRh68y0XC7OqZTKMIEelg7byTbpgIUy8Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711744699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cte94o80a4GQNU1FJtxqbsvEotPlQPShJxIf6TNq4nA=; b=tn7gl+KYrH8+XQNtDGhy/WMqN2PqhAKBTN0R4HjWZ8EV13p3qQXmHd0NdoinfHXlCdD1B9 +wRnZl8yrJ3EFhJ4OeyAsdM+f9WjhsGgkbci5vbGi8YWPscELF+3HpAq2BQ21DQmiV8hbP BEcrNT3jqgDzhuuKVbNTpLNTnB6jwsmHFHw1hFcDOVqaKmbfMLBBZT4qDk4F9D54Q9ld4H 4vtRUPP0slW5cvTq+4/ivpseBDNllv5UeKnYQWmbSO9FGoWsGb5KVXVyXM8VX0Zb5bm+h0 paX94ypGEw/9TQIcGv37GniFxa8bqthQshTY67cnUJlXtdvDuzsSyu6rwsN5XA== Received: from aniel.nours.eu (nours.eu [IPv6:2001:41d0:8:3a4d::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V5sgH4bWVzZDr; Fri, 29 Mar 2024 20:38:19 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id E5537180B3D; Fri, 29 Mar 2024 21:38:17 +0100 (CET) Date: Fri, 29 Mar 2024 21:38:17 +0100 From: Baptiste Daroussin To: Yuri Victorovich Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d22f15315b93 - main - devel/gmake43: Corrections Message-ID: References: <202403292007.42TK7lhI072363@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202403292007.42TK7lhI072363@gitrepo.freebsd.org> On Fri 29 Mar 20:07, Yuri Victorovich wrote: > The branch main has been updated by yuri: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=d22f15315b93dcbb96df76f9a4555ff201814fb6 > > commit d22f15315b93dcbb96df76f9a4555ff201814fb6 > Author: Yuri Victorovich > AuthorDate: 2024-03-29 20:02:40 +0000 > Commit: Yuri Victorovich > CommitDate: 2024-03-29 20:02:40 +0000 > > devel/gmake43: Corrections > > Reported by: Gleb Popov > --- > devel/gmake43/Makefile | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/devel/gmake43/Makefile b/devel/gmake43/Makefile > index f012ce4c0cec..508436255675 100644 > --- a/devel/gmake43/Makefile > +++ b/devel/gmake43/Makefile > @@ -5,10 +5,7 @@ MASTER_SITES= GNU/make > DISTNAME= make-${PORTVERSION} > PKGNAMESUFFIX= 43 > > -# note: before committing to this port, contact portmgr to arrange for an > -# experimental ports run. Untested commits may be backed out at portmgr's > -# discretion. > -MAINTAINER= tijl@FreeBSD.org > +MAINTAINER= yuri@FreeBSD.org > COMMENT= GNU version of 'make' utility > WWW= https://www.gnu.org/software/make/ This is wrong, because it conflicts with the regular gmake if you want to actually fix the issue of performance you faced, it would have been a good idea to start a discussion and 1/ the gmake maintainer, 2/ ports community including portmgr. Just speaking on what should be done if we are to revive gmake 4.3 first it needs to be done in a way which prevent collision with regular gmake: meaning the binary and all the installation should be in a different path and/or name than what the gmake provides like naming the binary gmake43. Second the framework (Uses/gmake.mk for instance) should grow a new option to chose gmake43, last it should only be used on ports where the regression has clearly be characterized. that is if we consider it is worth importing, which I don't think it is right now. >From what I could read we have a port seems to be abusing gmake and should probably be fixed to work properly with gmake43, doing this will benefit both upstream and us, so in my opinion we should not import here gmake43 neither follow the path I described above, but work with the only port which has an issue with gmake 4.4+ Best regards, Bapt