From nobody Tue Jun 7 15:13:58 2022 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9A2607FA425 for ; Tue, 7 Jun 2022 15:13:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LHYm63Gn2z4YB4 for ; Tue, 7 Jun 2022 15:13:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 508A61D054 for ; Tue, 7 Jun 2022 15:13:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 257FDwtZ031234 for ; Tue, 7 Jun 2022 15:13:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 257FDw10031233 for fs@FreeBSD.org; Tue, 7 Jun 2022 15:13:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 252316] [PATCH] add OCF offloading to ZFS Date: Tue, 07 Jun 2022 15:13:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jhb@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1654614838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7jpTcsFj5Yr7pyaeBIqjGgeiM30m673bORnrggK/eSM=; b=i0iCnI+xPYu3+3bH6zekxVZGccKaKNQs4dq8iD84dBG6UZRA3/ueM+DYx8poeYsHcD4o43 1VTYORn+wN5RsSYK4Pc+j+aao0sS2TxjuHjHvWrDuGu4e062/2Y68Ct6z6rikm98MfDv6i 9+EPubkecqpHra7u71LZQzFt3WgLwHfUpTFbPOCoGFUGA/zzjP4PJaQtJZ3OpuKwlFtuN2 U4surx3bBjuGraEn4w4iez7vtGfKVyoXSyl94JxewJcXO3Np8/cy+G/ozJEAbG9EnAmqT2 JP6TI3cjAokJXtnCZvOnF+KQP8xipz8ry+GF14RCdFExgmPyWJZt+HJSX66yXw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1654614838; a=rsa-sha256; cv=none; b=QU6LzLHv31hlQYz4BGB4fnBwRW5jZRCxMIsMbZHTBl5onP1nMzpheY330C+DW6ihomhGWZ nzaKY53OvUZhgZZ4uA9dDi0/BZwJ4gbqh2wNyPjEfnSL9OCwM/dMXGxRcT45u0yGXp23b/ J91YwGqtAxF5CwJHMUR8c6xtNKoGemjWwmLk4S7uAz1vKT//xPosInFOB699RE9uL1kN2W DMTZTrbM6GDKacMhVYLRp9BRoFB7iMt03SeEDD7of1TfBbgJMyL8WmR+30oXuYVvTBQtU5 V7KIy21LNZn2sdZJ1kF50gAafhm40cXSnVYQpwRyX5tGB3DKC95a3sw22Tl8ig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252316 --- Comment #5 from John Baldwin --- I don't think the patch is correct. I think the issue is probably that you aren't using a separate output buffer, and in the case that we aren't using= a separate buffer, we should just assert that the output_payload_start is 0 a= nd not check it otherwise. Or perhaps you are using the output only for the digest and not doing encryption? In that case your patch might indeed be correct. I think though in that case we'd like to assert that payload_output_start is not used (i.e. 0), something like: if (csp->mode =3D=3D CSP_MODE_DIGEST) KASSERT(payload_output_start =3D=3D 0) else /* existing test that output region fits in olen */ --=20 You are receiving this mail because: You are the assignee for the bug.=