From owner-freebsd-current@FreeBSD.ORG Wed Apr 23 19:09:28 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7433E1065675 for ; Wed, 23 Apr 2008 19:09:28 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (smtp5-g19.free.fr [212.27.42.35]) by mx1.freebsd.org (Postfix) with ESMTP id 1E8848FC14 for ; Wed, 23 Apr 2008 19:09:27 +0000 (UTC) (envelope-from tataz@tataz.chchile.org) Received: from smtp5-g19.free.fr (localhost.localdomain [127.0.0.1]) by smtp5-g19.free.fr (Postfix) with ESMTP id 83FFE3F61B0; Wed, 23 Apr 2008 21:09:26 +0200 (CEST) Received: from tatooine.tataz.chchile.org (tataz.chchile.org [82.233.239.98]) by smtp5-g19.free.fr (Postfix) with ESMTP id 2252E3F629F; Wed, 23 Apr 2008 21:09:24 +0200 (CEST) Received: from obiwan.tataz.chchile.org (unknown [192.168.1.25]) by tatooine.tataz.chchile.org (Postfix) with ESMTP id A7ECE9BF12; Wed, 23 Apr 2008 19:06:59 +0000 (UTC) Received: by obiwan.tataz.chchile.org (Postfix, from userid 1000) id 9A685405B; Wed, 23 Apr 2008 21:06:59 +0200 (CEST) Date: Wed, 23 Apr 2008 21:06:59 +0200 From: Jeremie Le Hen To: Eygene Ryabinkin Message-ID: <20080423190659.GT92168@obiwan.tataz.chchile.org> References: <72389.1197629858@critter.freebsd.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-06) Cc: freebsd-current@freebsd.org Subject: Re: [RFC] Automated generation of /etc/resolv.conf from the rc.d script X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Apr 2008 19:09:28 -0000 Hi Eygene, On Mon, Apr 14, 2008 at 07:44:13PM +0400, Eygene Ryabinkin wrote: > [...] > Testing and feedback are more than welcome. I didn't test your patch but I have a have a few comments about it: In install_new_file(), I don't think you should test for $CMP being an executable file... It is in the base system and the rule of thumb in other rc.d scripts is to use those directly. I'm not sure you should chown/chmod the forwarders file. People may have custom setup that you should not interfere with without a good reason. Also, I would rather let add_new_bind_forwarders() build the "empty" forwarders file, it would make more sense IMHO. You could then put a single call to add_new_bind_forwarders() at the end of the script under a $resolv_build_named_forwarders condition. It makes more sense indeed to test this outside of the function, my personal feeling being that it makes the reading less puzzling. Anyway, thank you very much for your work. I think many people will enjoy it once it will hit the source tree. Best regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org >