From owner-svn-src-head@freebsd.org Mon Jan 22 18:43:37 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E86EDECF416 for ; Mon, 22 Jan 2018 18:43:37 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-io0-f181.google.com (mail-io0-f181.google.com [209.85.223.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B87A568366 for ; Mon, 22 Jan 2018 18:43:37 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-io0-f181.google.com with SMTP id c17so10492757iod.1 for ; Mon, 22 Jan 2018 10:43:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:cc; bh=jE/Kjbu+DOTvsBLMHx2mpUGDeq+BWsHzyuCohIz62RM=; b=rr4192GIAegRQD0nNeB4yz5NmLdBPThWO19lWnKVeWvLIC3w6G55aLPnhI4FraYrvo W26uW5/KxmyrAlGqlvwGxEL+W1PRJIcyUtNl+mGnFFE6ZuEfYBlaHqncZwxH2F+c7f5E AdVscxNxQ9s2dUHXhe1L3ZxrbgmBXsmfOec4rZt8tLZKvefi81Ee7Hx7UAuOdTayRKB5 5FyPQ/CU1039UlAuttO/Z+xkolpku42k/UdNGr32o7NLzxHtpS7JXaDaJlzwamn+Lz0C 1kYJ0CqvggEVgHFoxoE+9U6lHwFSDbMyGqpCA7qlbX2HlY3NIQK/MU0YjR1MN1F0Sw9l W0CA== X-Gm-Message-State: AKwxytfio/16ACV0i7LmNS4AtrWb7nZJiPxL5bGjYkmhYZCmETAJS0U5 IECzWT3Jz3iq8ThWAt/zvKjdT1Y5 X-Google-Smtp-Source: AH8x224TXnZFNRYDQYU/yRkylGjRRmnOBc+uk/61mY8jCSno+8nciadzoM85L7G91qBftlM525z5Fg== X-Received: by 10.107.20.200 with SMTP id 191mr9554453iou.239.1516646611183; Mon, 22 Jan 2018 10:43:31 -0800 (PST) Received: from mail-io0-f180.google.com (mail-io0-f180.google.com. [209.85.223.180]) by smtp.gmail.com with ESMTPSA id r186sm4061881itb.13.2018.01.22.10.43.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2018 10:43:31 -0800 (PST) Received: by mail-io0-f180.google.com with SMTP id c17so10492679iod.1 for ; Mon, 22 Jan 2018 10:43:30 -0800 (PST) X-Received: by 10.107.20.200 with SMTP id 191mt10133123iou.239.1516646610576; Mon, 22 Jan 2018 10:43:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.157.12 with HTTP; Mon, 22 Jan 2018 10:43:10 -0800 (PST) In-Reply-To: <201801221840.w0MIeJls082586@repo.freebsd.org> References: <201801221840.w0MIeJls082586@repo.freebsd.org> From: Kyle Evans Date: Mon, 22 Jan 2018 12:43:10 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r328263 - head/lib/libregex Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 18:43:38 -0000 On Mon, Jan 22, 2018 at 12:40 PM, Kyle Evans wrote: > Author: kevans > Date: Mon Jan 22 18:40:19 2018 > New Revision: 328263 > URL: https://svnweb.freebsd.org/changeset/base/328263 > > Log: > libregex: Add a symbol map > > kib points out that trying to re-use symbol versioning from libc is dirty > and wrong. The implementation in libregex is incompatible by design with the > implementation in libc. Using the symbol versions from libc can and likely > will cause confusions for linkers and bring unexpected behavior for > consumers that unwillingly (transitively) link against libregex. > > Reported by: kib > Another thing I forgot to note here: libregex symbol versioning was actually not happening prior to this commit due to failure to define VERSION_DEF. This has also been corrected in this commit.