From owner-cvs-ports@FreeBSD.ORG Tue Sep 2 06:29:48 2008 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1033) id C08EF1065679; Tue, 2 Sep 2008 06:29:48 +0000 (UTC) Date: Tue, 2 Sep 2008 06:29:48 +0000 From: Alexey Dokuchaev To: Alexander Kabaev Message-ID: <20080902062948.GB18477@FreeBSD.org> References: <200808300526.m7U5QNUM070422@repoman.freebsd.org> <20080831092939.GA60104@FreeBSD.org> <20080831122400.3c12f314@kan.dnsalias.net> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20080831122400.3c12f314@kan.dnsalias.net> User-Agent: Mutt/1.4.2.1i Cc: Alexander Kabaev , cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/x11-toolkits/libxfce4gui Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Sep 2008 06:29:48 -0000 On Sun, Aug 31, 2008 at 12:24:00PM -0400, Alexander Kabaev wrote: > On Sun, 31 Aug 2008 09:29:39 +0000 > Alexey Dokuchaev wrote: > > On Sat, Aug 30, 2008 at 05:26:23AM +0000, Alexander Kabaev wrote: > > > kan 2008-08-30 05:26:23 UTC > > > > > > FreeBSD ports repository > > > > > > Modified files: > > > x11-toolkits/libxfce4gui Makefile > > > Log: > > > Add explicit dependency for libSM library. It is required for > > > XFCE components to be able to issue session-management requests to > > > xfce4-session, but is not pulled in by default when packages are > > > build on package cluster. > > > The user-visible effect of this omission was non-funtional Quit > > > button on xfce panel. > > > > Thanks for fixing, but reflecting maintainer's (oliver@) feeling about > > the change in the commit message would be nice. > > This is a Makefile change which is arguably a missing part of > conversion to modularized Xorg, not a change to the port itself. Oh, OK, sorry for the noise them. It just happened before that seemingly simple changes turned out being not quite right, so I thought I'd better ask. ./danfe