From owner-cvs-src@FreeBSD.ORG  Tue Aug  3 01:58:19 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 092F416A4CE; Tue,  3 Aug 2004 01:58:19 +0000 (GMT)
Received: from harmony.village.org (rover.village.org [168.103.84.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8554D43D68; Tue,  3 Aug 2004 01:58:16 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.11/8.12.11) with ESMTP id i731t87Z001744;
	Mon, 2 Aug 2004 19:55:08 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Mon, 02 Aug 2004 19:55:37 -0600 (MDT)
Message-Id: <20040802.195537.104022299.imp@bsdimp.com>
To: njl@FreeBSD.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200408030041.i730fl2S048673@repoman.freebsd.org>
References: <200408030041.i730fl2S048673@repoman.freebsd.org>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/eisa eisaconf.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Aug 2004 01:58:19 -0000

In message: <200408030041.i730fl2S048673@repoman.freebsd.org>
            Nate Lawson <njl@FreeBSD.org> writes:
: njl         2004-08-03 00:41:47 UTC
: 
:   FreeBSD src repository
: 
:   Modified files:
:     sys/dev/eisa         eisaconf.c 
:   Log:
:   Change EISA probing to be less invasive.  Instead of probing all slots
:   unconditionally, stop after the first one (system board) if no EISA hardware
:   is detected.  This fixes a boot hang (i.e. Thinkpad) when ACPI is disabled.
:   Also, split the probe code into a separate function and do some style cleanup.
:   
:   Note that the Adaptec 2842 VLB controller probe is broken by this change
:   and will fail to probe.  It should be fixed separately.

This change, btw, was reviewed by gibbs and imp prior to the
commit...  The 2842 VLB controller is about 13 years old.  There will
likely be a fix for it soon from the ahc maintainer.  However, even if
there isn't, the belief is that modern laptop owners with the eisa
hang problem is >> the 2842 controller.  I believe the re@ signed off
on this as well.

Warner