From owner-freebsd-net Mon Mar 19 10: 9:19 2001 Delivered-To: freebsd-net@freebsd.org Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193]) by hub.freebsd.org (Postfix) with ESMTP id DA0AF37B719 for ; Mon, 19 Mar 2001 10:09:16 -0800 (PST) (envelope-from wollman@khavrinen.lcs.mit.edu) Received: (from wollman@localhost) by khavrinen.lcs.mit.edu (8.9.3/8.9.3) id NAA94850; Mon, 19 Mar 2001 13:08:32 -0500 (EST) (envelope-from wollman) Date: Mon, 19 Mar 2001 13:08:32 -0500 (EST) From: Garrett Wollman Message-Id: <200103191808.NAA94850@khavrinen.lcs.mit.edu> To: Yar Tikhiy Cc: freebsd-net@FreeBSD.ORG Subject: Re: A few nasty bugs in the networking code In-Reply-To: <20010319205902.M43447@comp.chem.msu.su> References: <20010319203104.L43447@comp.chem.msu.su> <200103191732.SAA85848@info.iet.unipi.it> <20010319205902.M43447@comp.chem.msu.su> Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org < said: > if_delmulti() (net/if.c) does not notify a corresponding interface > driver when a _link-layer_ multicast group is being left. > There is a mtod() without a prior m_pullup() in netinet/if_ether.c. > The system might be likely to crash sometimes... > The vlan driver don't update byte/packet counters that it should to. > The vlan driver mishandles the interface flags. That may lead to Bad Things > like crashes sometimes... > The vlan driver's author got a wrong idea about the struct sockaddr_dl > contents when writing the code. It's also a good idea to check the return > value of malloc()... I have taken a look at all of these and your suggested fixes appear to be correct in concept. I have not tested any of them, however. -GAWollman To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message