From owner-freebsd-ports@FreeBSD.ORG Wed May 18 22:18:01 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 7D8C1106564A for ; Wed, 18 May 2011 22:18:01 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 65-241-43-5.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 9657A14E019; Wed, 18 May 2011 22:18:00 +0000 (UTC) Message-ID: <4DD44596.9050401@FreeBSD.org> Date: Wed, 18 May 2011 15:17:58 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.17) Gecko/20110429 Thunderbird/3.1.10 MIME-Version: 1.0 To: Matthew Seaman References: <4DD443DD.90909@infracaninophile.co.uk> In-Reply-To: <4DD443DD.90909@infracaninophile.co.uk> X-Enigmail-Version: 1.1.2 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-ports@freebsd.org Subject: Re: Optional Patches X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2011 22:18:01 -0000 On 05/18/2011 15:10, Matthew Seaman wrote: > # Testing both WITH_ and WITHOUT_ is a good idea... I'm not sure why you would need to test both, unless it's to catch wacky stuff coming in from the environment? The usual way is to test the opposite of the default. So for default on you would test that WITHOUT_FOO is not defined. Doug -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/