From owner-freebsd-arch@FreeBSD.ORG  Tue Jan 16 21:00:59 2007
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
X-Original-To: freebsd-arch@freebsd.org
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4573D16A66F
	for <freebsd-arch@freebsd.org>; Tue, 16 Jan 2007 21:00:59 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.189])
	by mx1.freebsd.org (Postfix) with ESMTP id B382A13C4BA
	for <freebsd-arch@freebsd.org>; Tue, 16 Jan 2007 21:00:56 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: by nf-out-0910.google.com with SMTP id k27so2516009nfc
	for <freebsd-arch@freebsd.org>; Tue, 16 Jan 2007 13:00:55 -0800 (PST)
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta;
	h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
	b=Q12o8UA/Wy2JUq7tjb8PCVX9cKBUmeqIUnn6w8TePJo3cO79yjdceWit2T3/M4yQd40PLgKybfnEpYu0Tebz+NCxmiieBdZZdkDqDqC6L/RafyCkVhJJhFujmHTL9T1L2sFmrPUiw7K3ie/Um0jxgr5dv8SzeUD2OlEKEmlyEGE=
Received: by 10.49.27.17 with SMTP id e17mr5583403nfj.1168981254082;
	Tue, 16 Jan 2007 13:00:54 -0800 (PST)
Received: by 10.48.238.9 with HTTP; Tue, 16 Jan 2007 13:00:54 -0800 (PST)
Message-ID: <3bbf2fe10701161300jc53b707h408fc0848767511f@mail.gmail.com>
Date: Tue, 16 Jan 2007 22:00:54 +0100
From: "Attilio Rao" <attilio@freebsd.org>
Sender: asmrookie@gmail.com
To: "John Polstra" <jdp@polstra.com>
In-Reply-To: <XFMail.20070116124314.jdp@polstra.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200701161438.52481.jhb@freebsd.org>
	<XFMail.20070116124314.jdp@polstra.com>
X-Google-Sender-Auth: 89b7436090da4470
Cc: Pawel Jakub Dawidek <pjd@freebsd.org>, Kip Macy <kip.macy@gmail.com>,
	Suleiman Souhlal <ssouhlal@freebsd.org>,
	freebsd-current@freebsd.org, freebsd-arch@freebsd.org
Subject: Re: [PATCH] Mantaining turnstile aligned to 128 bytes in i386 CPUs
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jan 2007 21:00:59 -0000

2007/1/16, John Polstra <jdp@polstra.com>:
> On 16-Jan-2007 John Baldwin wrote:
> > On Tuesday 16 January 2007 11:51, Attilio Rao wrote:
> >> The patch:
> >> http://users.gufi.org/~rookie/works/patches/ts-sq/ts-sq.diff
> >
> > Looks good.  Some minor nits are that in subr_turnstile.c in the comment I
> > would say "a turnstile is allocated" rather than "a turnstile is got from a
> > specific UMA zone" as it reads a little bit clearer.  Also, I would
> > say "Allocate a" rather than "Get a" for the two _alloc() functions.  Also,
> > why not just use UMA_ALIGN_CACHE and make UMA_ALIGN_CACHE (128 - 1) on i386
> > and amd64 rather than adding a new UMA_ALIGN_SYNC?
>
> Also, instead of calling bzero in the _init functions, I think you
> could pass UMA_ZONE_ZINIT to uma_zcreate.

Since it doesn't seem to be documented, it automatically zeros all the
initializations or just the first one?

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein