Date: Wed, 09 May 2007 09:42:23 -0700 From: Nate Lawson <nate@root.org> To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= <des@des.no> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libfetch fetch.3 ftp.c Message-ID: <4641F9EF.6030902@root.org> In-Reply-To: <861whqckm3.fsf@dwp.des.no> References: <200704222233.l3MMXUKH045452@repoman.freebsd.org> <86abwzio7t.fsf@dwp.des.no> <462CD3FD.6080300@root.org> <86tzurqp4d.fsf@dwp.des.no> <864pmn5lvd.fsf@dwp.des.no> <4640D8AA.40101@root.org> <86lkfzm2m7.fsf@dwp.des.no> <464172B0.4010507@root.org> <861whqckm3.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smørgrav wrote: > Nate Lawson <nate@root.org> writes: >> Could it be possible to check the values from the URL used to derive >> TYPE for RETR and then if it's the same as the value for MDTM, don't >> reissue it? Same for MODE. > > I suggest you look at the code. We *do* derive the TYPE value from > the URL. We do *not* trust the server state to be consistent from one > request to another. MDTM and RETR are two separate requests. Sorry, my message might have been unclear. I've looked at the code. > We *could* change the code to remember the last TYPE and MODE it > issued for the current server, and not issue new ones unnecessarily, > but we're quickly getting to the point where the FTP code needs a > major cleanup, at least when it comes to connection caching. This is what I was suggesting. I'll look into patching the current code to do this. If it's too hard, I'll skip it. -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4641F9EF.6030902>