From owner-freebsd-arm@FreeBSD.ORG Tue Jul 20 00:25:07 2010 Return-Path: Delivered-To: freebsd-arm@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 68E601065676 for ; Tue, 20 Jul 2010 00:25:07 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 2BA558FC08 for ; Tue, 20 Jul 2010 00:25:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o6K0LYAE050690; Mon, 19 Jul 2010 18:21:35 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 19 Jul 2010 18:22:02 -0600 (MDT) Message-Id: <20100719.182202.918765004097971572.imp@bsdimp.com> To: yohanes@gmail.com From: "M. Warner Losh" In-Reply-To: References: <4C444E8B.6090104@ansley.com> <20100719153614.GI28908@cicely7.cicely.de> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-arm@FreeBSD.org, ticso@cicely.de Subject: Re: at91sam9g20: Upcoming Patches X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2010 00:25:07 -0000 In message: Yohanes Nugroho writes: : On Mon, Jul 19, 2010 at 10:36 PM, Bernd Walter wrote: : >> if_ate.c: : >> : >> =A0 =A0* Support for sam9 "EMAC" controller. : >> =A0 =A0* Support for rmii interface to phy. : > : > RM9200 ate requires specific DMA alignment, which required a few : > realign copys. : > This isn't neccessary for most other AT91 devices and for sure : > not with any AT91SAM9x device. : > Not sure if all of them are automatically avoided - you might want : > to verify the code about this point. : > There is also RBNA workaround, which should be RM9200 specifc, : > which shouldn't be triggered with others, but you might want to sav= e : > a few bytes codespace. : = : And looking at Linux's code, they separate for the RM9200 driver and : newer AT9 (macb) drivers. I haven't looked deeply, but it seems that : if we are going to support all variations of RM9200 PHY for link : checking purpose, there will a lot of RM9200 specific code. Unlike Linux, all that's abstracted out in FreeBSD, so it is easy to support dozens of different PYHs. In fact, I don't think there's any PHY specific code in the current ATE driver... : I agree that there are many things in common between these two : drivers, but I don't know if it is a good idea to keep everything in : one file. Yea, I worry about the performance on newer parts of the older code, which has stinky performance due to hardware limitations. Warner