Date: Tue, 26 Jan 2021 09:52:20 +0800 From: Philip Paeps <philip@freebsd.org> To: Cy Schubert <cy@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 83edbc3cb54f - main - ipfilter: Retire pre-standard C support. Message-ID: <YA911GqWfTxylFBk@rincewind.trouble.is> In-Reply-To: <202101252247.10PMlBd2027258@gitrepo.freebsd.org> References: <202101252247.10PMlBd2027258@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2021-01-25 22:47:11 (+0000), Cy Schubert wrote: > ipfilter: Retire pre-standard C support. > > All C compilers in 2021 support standard C and architectures that did > not were retired long ago. Simplify by removing now redundant > pre-standard C code. [...] > #ifndef __P >-# ifdef __STDC__ > # define __P(x) x >-# else >-# define __P(x) () >-# endif >-#endif You could simplify even further by getting rid of the __P() convention altogether. All our compilers support prototypes in 2021. :) Philip -- Philip Paeps Senior Reality Engineer Alternative Enterprises
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YA911GqWfTxylFBk>