From owner-p4-projects@FreeBSD.ORG Mon Aug 11 17:54:02 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 8171E106567D; Mon, 11 Aug 2008 17:54:02 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4381E1065677 for ; Mon, 11 Aug 2008 17:54:02 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 320388FC1A for ; Mon, 11 Aug 2008 17:54:02 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m7BHs2Lh053031 for ; Mon, 11 Aug 2008 17:54:02 GMT (envelope-from hselasky@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m7BHs2Xd053029 for perforce@freebsd.org; Mon, 11 Aug 2008 17:54:02 GMT (envelope-from hselasky@FreeBSD.org) Date: Mon, 11 Aug 2008 17:54:02 GMT Message-Id: <200808111754.m7BHs2Xd053029@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to hselasky@FreeBSD.org using -f From: Hans Petter Selasky To: Perforce Change Reviews Cc: Subject: PERFORCE change 147163 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Aug 2008 17:54:02 -0000 http://perforce.freebsd.org/chv.cgi?CH=147163 Change 147163 by hselasky@hselasky_laptop001 on 2008/08/11 17:53:11 Add missing locking of "usb2_mtx". Caught by an mtx_assert() . Affected files ... .. //depot/projects/usb/src/sys/dev/usb2/core/usb2_transfer.c#19 edit Differences ... ==== //depot/projects/usb/src/sys/dev/usb2/core/usb2_transfer.c#19 (text+ko) ==== @@ -2322,6 +2322,7 @@ * If the current USB transfer is completing we need to start the * next one: */ + mtx_lock(xfer->usb2_mtx); if (pipe->pipe_q.curr == xfer) { usb2_command_wrapper(&(pipe->pipe_q), NULL); @@ -2333,6 +2334,7 @@ xfer->pipe->is_synced = 0; } } + mtx_unlock(xfer->usb2_mtx); done: return (0); }