From owner-freebsd-current  Sat Oct 21 12:17:25 2000
Delivered-To: freebsd-current@freebsd.org
Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11])
	by hub.freebsd.org (Postfix) with SMTP
	id EC6D237B4CF; Sat, 21 Oct 2000 12:17:20 -0700 (PDT)
Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP
          id <aa35845@salmon>; 21 Oct 2000 20:17:19 +0100 (BST)
Date: Sat, 21 Oct 2000 20:17:14 +0100
From: David Malone <dwmalone@maths.tcd.ie>
To: Garrett Rooney <rooneg@electricjellyfish.net>
Cc: Andrea Campi <andrea.campi@it.worldonline.com>,
	current@freebsd.org, Poul-Henning Kamp <phk@freebsd.org>,
	josh@zipperup.org, robd@gmx.net
Subject: Re: Junior Kernel Hacker Task:  M_ZERO
Message-ID: <20001021201714.A59209@walton.maths.tcd.ie>
References: <17100.972069144@critter> <008201c03b61$0e90a1c0$0304cdd5@oemcomputer> <20001021094847.A6934@electricjellyfish.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20001021094847.A6934@electricjellyfish.net>; from rooneg@electricjellyfish.net on Sat, Oct 21, 2000 at 09:48:47AM -0400
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Sat, Oct 21, 2000 at 09:48:47AM -0400, Garrett Rooney wrote:
> > If anybody is looking for a simple task to perform in the FreeBSD
> > kernel: this is it.
> > 
> > A quick grep tells me that there are at least 91 files in the src/sys
> > tree which could use this flag to simplify and optimize the code.
> 
> i'll probably start looking at these this week sometime...
> 
> something to pass the time in class i suppose.

Before anyone else starts looking at this, I've collected and
cleaned up the patches I've recieved so far and produced a big diff
at:

	http://www.maths.tcd.ie/~dwmalone/thirdtry

If you do find more of these remember to make sure the style in
which you make the patch matches the surounding code. Also, please
submit unified diffs - they are much easier to review for changes
like this. If you can, make sure the code compiles before submitting
it.

Other than style changes, I've included a list of other changes I've
made to the submitted patches.

	David.

sys/dev/aic7xxx/aic7xxx_freebsd.c
        Missing , in call to malloc in the patch.

sys/alpha/alpha/busdma_machdep.c
sys/ia64/ia64/busdma_machdep.c
        Replace a sizeof(**mapp) with sizeof(*map) - they are the same
        but the second makes more sense. (this was in original code)

sys/dev/usb/ohci.c
sys/dev/usb/uhci.c
        Fix one bug in patch where xfer would not be zeroed if it came
        off the free list.

sys/i386/include/mutex.h
        Patch reverted one of jhb's changes.

sys/i386/isa/cx.c
        Changes were in code not used by FreeBSD, so I removed them.
        (There was also a syntax error in the patch).

sys/kern/vfs_cache.c
        Patch zeroed more memory than original code - stick with original.

sys/netinet/ip_dummynet.c
        Preserve some comments that were removed by patch.

sys/netipx/ipx.c
sys/netns/ns.c
        sizeof(*oia) and sizeof(*ia) not obviously the same - stick with
        original code.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message