Date: Tue, 21 Sep 2010 11:57:16 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Renato Botelho <garga@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/monast Makefile pkg-plist ports/www/monast/files monast.in Message-ID: <4C99000C.2080205@FreeBSD.org> In-Reply-To: <201009211539.o8LFdg7p016823@repoman.freebsd.org> References: <201009211539.o8LFdg7p016823@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/21/2010 8:39 AM, Renato Botelho wrote: > garga 2010-09-21 15:39:42 UTC > > FreeBSD ports repository > > Modified files: > www/monast Makefile pkg-plist > Added files: > www/monast/files monast.in > Log: > - Remove unecessary patch and convert it to REINPLACE_CMD > - Respect PREFIX > - Use USE_RC_SUBR instead of install startup script manually Yay. :) Just one nit, you can't have REQUIRE and BEFORE with the same targets. I think the REQUIRE can just be removed in the script. You might also consider adding a $FreeBSD$. Otherwise looks great! > - Simplify mkdirs > > Revision Changes Path > 1.2 +8 -11 ports/www/monast/Makefile > 1.1 +27 -0 ports/www/monast/files/monast.in (new) > 1.2 +0 -1 ports/www/monast/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/monast/Makefile.diff?&r1=1.1&r2=1.2&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/monast/files/monast.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/monast/pkg-plist.diff?&r1=1.1&r2=1.2&f=h > -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C99000C.2080205>