From owner-p4-projects@FreeBSD.ORG Wed Jan 17 22:34:18 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 6280C16A416; Wed, 17 Jan 2007 22:34:18 +0000 (UTC) X-Original-To: perforce@FreeBSD.org Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2567A16A407 for ; Wed, 17 Jan 2007 22:34:18 +0000 (UTC) (envelope-from rdivacky@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 177F113C44C for ; Wed, 17 Jan 2007 22:34:18 +0000 (UTC) (envelope-from rdivacky@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l0HMYHbY076057 for ; Wed, 17 Jan 2007 22:34:17 GMT (envelope-from rdivacky@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l0HMYHXj076054 for perforce@freebsd.org; Wed, 17 Jan 2007 22:34:17 GMT (envelope-from rdivacky@FreeBSD.org) Date: Wed, 17 Jan 2007 22:34:17 GMT Message-Id: <200701172234.l0HMYHXj076054@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to rdivacky@FreeBSD.org using -f From: Roman Divacky To: Perforce Change Reviews Cc: Subject: PERFORCE change 113077 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2007 22:34:18 -0000 http://perforce.freebsd.org/chv.cgi?CH=113077 Change 113077 by rdivacky@rdivacky_witten on 2007/01/17 22:33:40 Dont expose em->shared to the outside world before its properly initialized. Might not affect anything but its at least a better coding style. Affected files ... .. //depot/projects/linuxolator/src/sys/compat/linux/linux_emul.c#21 edit Differences ... ==== //depot/projects/linuxolator/src/sys/compat/linux/linux_emul.c#21 (text+ko) ==== @@ -91,11 +91,11 @@ struct linux_emuldata_shared *s; s = malloc(sizeof *s, M_LINUX, M_WAITOK | M_ZERO); - em->shared = s; s->refs = 1; s->group_pid = child; LIST_INIT(&s->threads); + em->shared = s; } p = pfind(child); KASSERT(p != NULL, ("process not found in proc_init\n"));