From owner-freebsd-current Fri Apr 3 09:38:17 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id JAA06434 for freebsd-current-outgoing; Fri, 3 Apr 1998 09:38:17 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from critter.freebsd.dk (critter.freebsd.dk [195.8.129.14]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA06428 for ; Fri, 3 Apr 1998 09:38:13 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.8.7/8.8.5) with ESMTP id TAA02734; Fri, 3 Apr 1998 19:37:24 +0200 (CEST) To: =?koi8-r?B?4c7E0sXKIP7F0s7P1w==?= cc: "Alok K. Dhir" , current@FreeBSD.ORG, adkin003@tc.umn.edu Subject: Re: More info RE: X slowdown in -current In-reply-to: Your message of "Fri, 03 Apr 1998 21:12:12 +0400." <19980403211212.09449@nagual.pp.ru> Date: Fri, 03 Apr 1998 19:37:24 +0200 Message-ID: <2732.891625044@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <19980403211212.09449@nagual.pp.ru>, =?koi8-r?B?4c7E0sXKIP7F0s7P1w== ?= writes: >On Fri, Apr 03, 1998 at 07:08:12PM +0200, Poul-Henning Kamp wrote: >> In message , " >Alok >> K. Dhir" writes: >> > >> >This patch worked great. Is there any reason why it shouldn't be >> >committed? >> >> Yes there is a reason: it is wrong, it lacks a splhigh(). >> >> Please report on the version currently in -current. > > >This report/patch already *IS* for very latest version currently in >-current, your fix really fix nothing, the bug remains. Are you sure you are looking at 1.35 ? If you compare version 1.33 and 1.35 you will see that there is no change in spl() placement and protection. I simply fail to see what the heck you think you need to fuck with splhigh for... Try to diff 1.33 and 1.35 and see what I mean... -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." "Drink MONO-tonic, it goes down but it will NEVER come back up!" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message