From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jun 30 14:50:21 2008 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8A16A1065672 for ; Mon, 30 Jun 2008 14:50:21 +0000 (UTC) (envelope-from freebsdports@bindone.de) Received: from mail.bindone.de (mail.bindone.de [80.190.134.51]) by mx1.freebsd.org (Postfix) with SMTP id 030558FC1E for ; Mon, 30 Jun 2008 14:50:20 +0000 (UTC) (envelope-from freebsdports@bindone.de) Received: (qmail 59539 invoked by uid 89); 30 Jun 2008 14:23:38 -0000 Received: from unknown (HELO bombat.bindone.de) (mg@bindone.de@84.151.224.203) by mail.bindone.de with ESMTPA; 30 Jun 2008 14:23:38 -0000 Message-ID: <4868EC56.1050601@bindone.de> Date: Mon, 30 Jun 2008 16:23:18 +0200 From: Michael User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8.1.6) Gecko/20070818 SeaMonkey/1.1.4 MIME-Version: 1.0 To: "freebsd-ports-bugs@freebsd.org" References: <20080621174448.78623.qmail@mail.bindone.de> In-Reply-To: <20080621174448.78623.qmail@mail.bindone.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: shaun@FreeBSD.org Subject: Re: ports/124841: [PATCH] devel/zthread: Fix signature in BlockingQueue.h X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jun 2008 14:50:21 -0000 Any chance this one will be submitted any time soon? Michael wrote: >> Number: 124841 >> Category: ports >> Synopsis: [PATCH] devel/zthread: Fix signature in BlockingQueue.h >> Confidential: no >> Severity: non-critical >> Priority: low >> Responsible: freebsd-ports-bugs >> State: open >> Quarter: >> Keywords: >> Date-Required: >> Class: change-request >> Submitter-Id: current-users >> Arrival-Date: Sat Jun 21 17:50:00 UTC 2008 >> Closed-Date: >> Last-Modified: >> Originator: Michael Gmelin >> Release: FreeBSD 6.2-RELEASE-p3 i386 >> Organization: > /bin/done digital solutions GmbH >> Environment: > System: FreeBSD bombat.bindone.de 6.2-RELEASE-p3 FreeBSD 6.2-RELEASE-p3 #24: Wed May 16 20:01:05 CEST 2007 >> Description: > Two patches, one to fix a signed to unsigned comparison in Barrier.h and > more importantly a fix of the signature of the overloaded > bool BlockingQueue::add(item, timeout) member function in BlockingQueue.h, > which rendered using the feature impossible. > > Since my previous attempts to contact Eric about other patches were not > successful and therefore I do not expect new releases of ZThread anytime in > the near future, I suggest fixing this in the port skeleton. > > Portlint complained about an old README.html in the port as well, you might > consider removing this when applying these patches. > > Added file(s): > - files/patch-include_zthread_Barrier.h > - files/patch-include_zthread_BlockingQueue.h > > Port maintainer (shaun@FreeBSD.org) is cc'd. > > Generated with FreeBSD Port Tools 0.77 >> How-To-Repeat: >> Fix: > > --- zthread-2.3.2_1.patch begins here --- > diff -ruN --exclude=CVS /usr/ports/devel/zthread.orig/Makefile /usr/ports/devel/zthread/Makefile > --- /usr/ports/devel/zthread.orig/Makefile Sat Apr 21 17:17:27 2007 > +++ /usr/ports/devel/zthread/Makefile Sat Jun 21 19:21:00 2008 > @@ -7,6 +7,7 @@ > > PORTNAME= zthread > PORTVERSION= 2.3.2 > +PORTREVISION= 1 > CATEGORIES= devel > MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} > MASTER_SITE_SUBDIR= ${PORTNAME} > diff -ruN --exclude=CVS /usr/ports/devel/zthread.orig/files/patch-include_zthread_Barrier.h /usr/ports/devel/zthread/files/patch-include_zthread_Barrier.h > --- /usr/ports/devel/zthread.orig/files/patch-include_zthread_Barrier.h Thu Jan 1 01:00:00 1970 > +++ /usr/ports/devel/zthread/files/patch-include_zthread_Barrier.h Sat Jun 21 19:24:26 2008 > @@ -0,0 +1,20 @@ > +--- include/zthread/Barrier.h.orig Sun Mar 13 06:23:00 2005 > ++++ include/zthread/Barrier.h Sat Jun 21 17:31:14 2008 > +@@ -150,7 +150,7 @@ > + > + } else { > + > +- int myGeneration = _generation; > ++ unsigned int myGeneration = _generation; > + > + try { > + > +@@ -251,7 +251,7 @@ > + > + } else { > + > +- int myGeneration = _generation; > ++ unsigned int myGeneration = _generation; > + > + try { > + > diff -ruN --exclude=CVS /usr/ports/devel/zthread.orig/files/patch-include_zthread_BlockingQueue.h /usr/ports/devel/zthread/files/patch-include_zthread_BlockingQueue.h > --- /usr/ports/devel/zthread.orig/files/patch-include_zthread_BlockingQueue.h Thu Jan 1 01:00:00 1970 > +++ /usr/ports/devel/zthread/files/patch-include_zthread_BlockingQueue.h Sat Jun 21 19:19:17 2008 > @@ -0,0 +1,11 @@ > +--- include/zthread/BlockingQueue.h.orig Sun Mar 13 03:04:18 2005 > ++++ include/zthread/BlockingQueue.h Sat Jun 21 17:31:14 2008 > +@@ -83,7 +83,7 @@ > + /** > + * @see Queue::add(const T& item, unsigned long timeout) > + */ > +- virtual bool add(T item, unsigned long timeout) { > ++ virtual bool add(const T& item, unsigned long timeout) { > + > + try { > + > --- zthread-2.3.2_1.patch ends here --- > >> Release-Note: >> Audit-Trail: >> Unformatted: > _______________________________________________ > freebsd-ports-bugs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs > To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"