From owner-svn-ports-all@freebsd.org  Sun Feb 17 17:10:30 2019
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9C7FC14D5C93;
 Sun, 17 Feb 2019 17:10:30 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 3F3DC76671;
 Sun, 17 Feb 2019 17:10:30 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 29845C7EA; Sun, 17 Feb 2019 17:10:30 +0000 (UTC)
Date: Sun, 17 Feb 2019 17:10:30 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Thomas Zander <riggs@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r493169 - head/sysutils/xfce4-bsdcpufreq-plugin
Message-ID: <20190217171030.GA31946@FreeBSD.org>
References: <201902171525.x1HFPxZc001095@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201902171525.x1HFPxZc001095@repo.freebsd.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: 3F3DC76671
X-Spamd-Bar: --
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-2.85 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_HAM_MEDIUM(-0.99)[-0.993,0];
 NEURAL_HAM_SHORT(-0.86)[-0.857,0];
 NEURAL_HAM_LONG(-1.00)[-0.997,0];
 ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Feb 2019 17:10:30 -0000

On Sun, Feb 17, 2019 at 03:25:59PM +0000, Thomas Zander wrote:
> New Revision: 493169
> URL: https://svnweb.freebsd.org/changeset/ports/493169
> 
> Log:
>   Modernise port Makefile
>   
> ...
> -USE_GITHUB=	yes
> -GH_ACCOUNT=	riggs-
> -GH_TAGNAME=	be17b3a
> -
> -USE_GNOME=	gtk20
> -
>  USES=		pkgconfig xfce
>  USE_XFCE=	panel
> +USE_GNOME=	cairo gdkpixbuf2 gtk20
>  
>  PLIST_FILES=	lib/xfce4/panel/plugins/libbsdcpufreq.so \
>  		share/xfce4/panel/plugins/bsdcpufreq.desktop
> +
> +USE_GITHUB=	yes
> +GH_ACCOUNT=	riggs-
> +GH_TAGNAME=	be17b3a

GH_* knobs (fetch-related, earlier stage) should not go below PLIST_FILES
(packaging-related, later stage), it's just unnatural.

./danfe