From owner-freebsd-current Sun Feb 15 13:24:38 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA23782 for freebsd-current-outgoing; Sun, 15 Feb 1998 13:24:38 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from allegro.lemis.com (allegro.lemis.com [192.109.197.134]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA23770 for ; Sun, 15 Feb 1998 13:24:31 -0800 (PST) (envelope-from grog@lemis.com) Received: from freebie.lemis.com (freebie.lemis.com [192.109.197.137]) by allegro.lemis.com (8.8.7/8.8.5) with ESMTP id HAA25446; Mon, 16 Feb 1998 07:54:22 +1030 (CST) Received: (from grog@localhost) by freebie.lemis.com (8.8.8/8.8.7) id HAA24468; Mon, 16 Feb 1998 07:54:22 +1030 (CST) (envelope-from grog) Message-ID: <19980216075421.52560@freebie.lemis.com> Date: Mon, 16 Feb 1998 07:54:21 +1030 From: Greg Lehey To: "Jordan K. Hubbard" Cc: Chris Csanady , freebsd-current@FreeBSD.ORG Subject: Re: CCD missing spl() call.. References: <19980215191452.63038@freebie.lemis.com> <20539.887533728@time.cdrom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.89i In-Reply-To: <20539.887533728@time.cdrom.com>; from Jordan K. Hubbard on Sun, Feb 15, 1998 at 01:08:48AM -0800 WWW-Home-Page: http://www.lemis.com/~grog Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-41-739-7062 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, 15 February 1998 at 1:08:48 -0800, Jordan K. Hubbard wrote: >> (omitting some #ifdef DEBUG stuff) >> >> s = splbio(); >> >> if (cbp->cb_buf.b_flags & B_ERROR) { > > Erm.. You're in ccdiodone(), Yup. > a completely different function from the one I (and the submitted > patch) was referring to. :-) I don't know what function you were referring to, since you don't mention the name. All I have to go on is the original patch: *************** *** 973,978 **** --- 973,979 ---- register int unit = cbp->cb_unit; int count, s; + s = splbio(); #ifdef DEBUG if (ccddebug & CCDB_FOLLOW) printf("ccdiodone(%x)\n", cbp); This patch definitely applies to ccdiodone. Look at the text in the last line of the patch. What do you have at line 976 of your copy of /usr/src/sys/dev/ccd/ccd.c? Greg To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message