From owner-freebsd-current  Sat Nov 18  9:45:52 2000
Delivered-To: freebsd-current@freebsd.org
Received: from mail.interware.hu (mail.interware.hu [195.70.32.130])
	by hub.freebsd.org (Postfix) with ESMTP id 638B637B479
	for <current@freebsd.org>; Sat, 18 Nov 2000 09:45:49 -0800 (PST)
Received: from marakesh-10.budapest.interware.hu ([195.70.50.138] helo=elischer.org)
	by mail.interware.hu with esmtp (Exim 3.16 #1 (Debian))
	id 13xC3b-0006go-00; Sat, 18 Nov 2000 18:45:44 +0100
Message-ID: <3A16C021.FAF9B3A9@elischer.org>
Date: Sat, 18 Nov 2000 09:45:05 -0800
From: Julian Elischer <julian@elischer.org>
X-Mailer: Mozilla 4.7 [en] (X11; U; FreeBSD 5.0-CURRENT i386)
X-Accept-Language: en
MIME-Version: 1.0
To: Poul-Henning Kamp <phk@critter.freebsd.dk>
Cc: David Malone <dwmalone@maths.tcd.ie>, current@freebsd.org
Subject: Re: Typo in labpc.c
References: <33162.974578284@critter>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Poul-Henning Kamp wrote:
> 
> In message <200011181723.aa82033@salmon.maths.tcd.ie>, David Malone writes:
> >I noticed the following while looking through the M_ZERO patches.
> >When you were cleaning up some dev stuff you made the following
> >change to labpc.c (revision 1.33):
> >
> >
> >        labpcs = malloc(NLABPC * sizeof(struct ctlr *), M_DEVBUF, M_NOWAIT);
> >        if (labpcs)
> >        {
> >                bzero(labpcs, NLABPC * sizeof(struct ctlr *));
> >                return 1;
> >        }
> >+       cdevsw_add(&labpc_cdevsw);
> >        return 0;
> > }
> >
> >This seems to only do the cdevsw_add if the malloc failed. I presume
> >this is the opposit of the intended sense. I'll fix it up if you also
> >think it looks wrong.
> 
> If nobody have noticed in "17 months, 2 weeks ago" (as cvs-web says)
> that labpc doesn't work, the labpc driver should be killed, not fixed.
> 
> Objections ?

What you are saying is that people who may be using this driver have 
not yet moved up to -current or 4.x and as such should not be allowed
to?

I see no harm in leaving it there..

leave that axe right where it is....



> 
> --
> Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
> phk@FreeBSD.ORG         | TCP/IP since RFC 956
> FreeBSD committer       | BSD since 4.3-tahoe
> Never attribute to malice what can adequately be explained by incompetence.
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-current" in the body of the message

-- 
      __--_|\  Julian Elischer
     /       \ julian@elischer.org
    (   OZ    ) World tour 2000
---> X_.---._/  presently in:  Budapest
            v


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message