From owner-freebsd-bugs  Sat Aug 14 13:30:42 1999
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id CF5F814D4E
	for <freebsd-bugs@FreeBSD.org>; Sat, 14 Aug 1999 13:30:39 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id NAA50897;
	Sat, 14 Aug 1999 13:30:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 2864F14D4E
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 14 Aug 1999 13:30:33 -0700 (PDT)
	(envelope-from adrian@FreeBSD.org)
Received: (from adrian@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id NAA50837;
	Sat, 14 Aug 1999 13:29:43 -0700 (PDT)
	(envelope-from adrian@FreeBSD.org)
Message-Id: <199908142029.NAA50837@freefall.freebsd.org>
Date: Sat, 14 Aug 1999 13:29:43 -0700 (PDT)
From: adrian@freebsd.org
Reply-To: adrian@freebsd.org
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: bin/13143: changing mount flags on a mounted filesystem not in fstab segfaults mount(8)
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         13143
>Category:       bin
>Synopsis:       changing mount flags on a mounted filesystem not in fstab segfaults mount(8)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Aug 14 13:30:01 PDT 1999
>Closed-Date:
>Last-Modified:
>Originator:     Adrian Chadd
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
bin
>Environment:

FreeBSD ywing.m2.ip.versatel.net 4.0-CURRENT FreeBSD 4.0-CURRENT #6: Fri Aug 13 20:09:12 CEST 1999

>Description:

When you attempt to modify the mount flags of a mounted filesystem NOT in
/etc/fstab, you segfault mount.

>How-To-Repeat:

$ /sbin/mount -u -o rw /mnt
Segmentation fault - core dumped

>Fix:

Fix update_options to not strdup() a NULL string -

Index: mount.c
===================================================================
RCS file: /home/ncvs/src/sbin/mount/mount.c,v
retrieving revision 1.31
diff -u -r1.31 mount.c
--- mount.c     1999/05/07 05:31:00     1.31
+++ mount.c     1999/08/14 20:16:04
@@ -594,7 +594,11 @@
        if (opts == NULL)
                return strdup("");
 
-       fstab = strdup(fstab);
+       if (fstab == NULL) {
+               fstab = strdup("");
+       } else {
+               fstab = strdup(fstab);
+       }
 
        /* remove meta options from list */
        remopt(fstab, MOUNT_META_OPTION_FSTAB);

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message