From owner-svn-src-all@freebsd.org  Sun Nov  5 20:15:13 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4A256E5040F;
 Sun,  5 Nov 2017 20:15:13 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B309D6954C;
 Sun,  5 Nov 2017 20:15:12 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id vA5KF3Sc089089
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Sun, 5 Nov 2017 22:15:03 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua vA5KF3Sc089089
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id vA5KF3qD089088;
 Sun, 5 Nov 2017 22:15:03 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Sun, 5 Nov 2017 22:15:03 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: Ian Lepore <ian@freebsd.org>
Cc: cem@freebsd.org, Andriy Gapon <avg@freebsd.org>,
 Warner Losh <imp@bsdimp.com>, src-committers <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject: Re: svn commit: r325386 - head/sys/kern
Message-ID: <20171105201503.GH2566@kib.kiev.ua>
References: <CAG6CVpUaXSX26Bc839kn96EXnUjtGyQ3_eNJPhsRB+v6G6gH1Q@mail.gmail.com>
 <20171105130607.GA2566@kib.kiev.ua>
 <CAG6CVpV3SfV8VuNeMJEuN+MSu3424mK=HO_-YW9vRt9HEdcJZQ@mail.gmail.com>
 <20171105173032.GE2566@kib.kiev.ua>
 <CAG6CVpVQ4RSgz883ezsdExVDQ4RbSiR_y+Z5XWDNFeYBpMS-cQ@mail.gmail.com>
 <CANCZdfqApxd99G-HqVfe4x8EysYJVCAcHksqTeUuBAaYR1OjEA@mail.gmail.com>
 <20171105190214.GG2566@kib.kiev.ua>
 <20f694b3-c60c-1b6d-76a1-2ef14cbdd698@FreeBSD.org>
 <CAG6CVpUuQ-LP9P0ckkkv4Y07aowEhT3qj8e45AK-Nnzhh_LnMA@mail.gmail.com>
 <1509910670.99235.70.camel@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1509910670.99235.70.camel@freebsd.org>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Nov 2017 20:15:13 -0000

On Sun, Nov 05, 2017 at 12:37:50PM -0700, Ian Lepore wrote:
> IMO, the only reason ASSERT-style macros exist is to hide the
> conditional-on-build-type part of the operation. šThat is, to avoid
> having #ifdef INVARIANTS scattered everywhere.
bde' point is that KASSERT() is badly designed, and I agree with him.
Now we could at least remove the () around the message formatting part,
but it is too late.

> 
> Creating a macro to generate always-on error detection and reporting
> code just because there exists a macro to do so conditionally seems to
> turn the world on its head.
I agree with this statement.  if()panic(); construct is good enough, IMO.