From owner-cvs-all Sun Sep 10 5:41: 1 2000 Delivered-To: cvs-all@freebsd.org Received: from anchor-post-32.mail.demon.net (anchor-post-32.mail.demon.net [194.217.242.90]) by hub.freebsd.org (Postfix) with ESMTP id E73D337B423; Sun, 10 Sep 2000 05:40:56 -0700 (PDT) Received: from nlsys.demon.co.uk ([158.152.125.33] helo=herring.nlsystems.com) by anchor-post-32.mail.demon.net with esmtp (Exim 2.12 #1) id 13Y6Pg-0009FP-0W; Sun, 10 Sep 2000 13:40:49 +0100 Received: from salmon.nlsystems.com (salmon.nlsystems.com [10.0.0.3]) by herring.nlsystems.com (8.9.3/8.8.8) with ESMTP id NAA21550; Sun, 10 Sep 2000 13:42:15 +0100 (BST) (envelope-from dfr@nlsystems.com) Date: Sun, 10 Sep 2000 13:41:13 +0100 (BST) From: Doug Rabson To: Peter Wemm Cc: Jason Evans , cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_malloc.c In-Reply-To: <200009100059.e8A0xCG75517@netplex.com.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, 9 Sep 2000, Peter Wemm wrote: > Jason Evans wrote: > > jasone 2000/09/09 15:27:35 PDT > > > > Modified files: > > sys/kern kern_malloc.c > > Log: > > Add a mutex to the malloc interfaces so that it can safely be called > > without owning the Giant lock. > > This isn't safe.. It still calls kmem_malloc() which grovels around > in the VM system. If you call malloc without Giant, you risk destroying > the VM system as you would be calling it without Giant held. The right thing to do here is probably to drop the malloc mutex and take the the Giant mutex before calling kmem_malloc(). -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 20 8348 3944 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message