From owner-freebsd-net@FreeBSD.ORG Sat Sep 2 07:52:46 2006 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E48A16A600 for ; Sat, 2 Sep 2006 07:52:46 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id A602F43D53 for ; Sat, 2 Sep 2006 07:52:44 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 93955 invoked from network); 2 Sep 2006 07:38:32 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 2 Sep 2006 07:38:32 -0000 Message-ID: <44F9384C.9070902@freebsd.org> Date: Sat, 02 Sep 2006 09:52:44 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: Jack Vogel References: <2a41acea0609011551v40338539u4eef48d091dd12ab@mail.gmail.com> In-Reply-To: <2a41acea0609011551v40338539u4eef48d091dd12ab@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-net , freebsd-current Subject: Re: RFC: TSO patch for current X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Sep 2006 07:52:46 -0000 Jack Vogel wrote: > This is a patch for the stack and the em driver to enable TSO > on CURRENT. Previously I had problems getting it to work, but > this is functional. > > I should note that CURRENT is being a pain right now, when > I comment out em in the config the kernel panics coming up, > so I had to substitute this code into the tree. Rather bizarre :) > > I have this functionality running on a 6.1 based system, and > our test group is already testing against that driver, so far > things are looking good. > > I have designed it so the driver can continue to be built > without support. There is also a sysctl in the stack code > so you can set net.inet.tcp.tso_enable on or off and > compare. > > I know there may be some refinements to add in, but I > would like to get this into CURRENT as a start. I can't comment on the em part but the tcp_output.c stuff looks very much like a straight port from NetBSD. If we take code from the other BSDs we have to remark this in the emails we send with patches and the commit message (otherwise we get accused of 'stealing without attribution'). Although the code would work I have some ideas to implement this in a different way for our stack (we have certain divergence from the other BSDs). If you don't get an alternative patch form me until this Thursday be free to go with this patch taking into consideration Robert's comments and mine from your earlier version. -- Andre