From owner-cvs-src@FreeBSD.ORG Sun Apr 27 17:49:52 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E7D101065670; Sun, 27 Apr 2008 17:49:52 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.freebsd.org (Postfix) with ESMTP id B78628FC14; Sun, 27 Apr 2008 17:49:52 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (uwzjd6wdh0zcjvok@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id m3RHnq3d025722; Sun, 27 Apr 2008 10:49:52 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id m3RHnpCA025721; Sun, 27 Apr 2008 10:49:51 -0700 (PDT) (envelope-from jmg) Date: Sun, 27 Apr 2008 10:49:51 -0700 From: John-Mark Gurney To: Robert Watson Message-ID: <20080427174951.GJ82555@funkthat.com> References: <200804271550.m3RFo0R6071940@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200804271550.m3RFo0R6071940@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (hydrogen.funkthat.com [127.0.0.1]); Sun, 27 Apr 2008 10:49:52 -0700 (PDT) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Apr 2008 17:49:53 -0000 Robert Watson wrote this message on Sun, Apr 27, 2008 at 15:50 +0000: > Note that the current fix isn't perfect, but better than > panicking: normally we guarantee that simultaneous invocations > of a system call to write on a stream socket won't be > interlaced, which is ensured by use of the socket buffer sleep > lock. This is guaranteed for the sendfile headers, but not > trailers. In practice, this is likely not a problem, but > should be fixed. Should this be mentioned in the BUGS section of the sendfile(2) man page? or do you plan on fixing this in the near future? -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."