From owner-svn-ports-all@FreeBSD.ORG Fri Jan 17 22:42:35 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 033FBED9; Fri, 17 Jan 2014 22:42:35 +0000 (UTC) Received: from mail-wg0-x236.google.com (mail-wg0-x236.google.com [IPv6:2a00:1450:400c:c00::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E2C8C12AE; Fri, 17 Jan 2014 22:42:33 +0000 (UTC) Received: by mail-wg0-f54.google.com with SMTP id x13so5007647wgg.33 for ; Fri, 17 Jan 2014 14:42:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=wkTVmwWyMzrQ48MuLlvJT8fZrGamin/UZBBddrSknfE=; b=M0cSF/huHQzi8Bi4VO3Z67gVZG9INIf8NB3BgSn8+p7+5iSX/HPafV6YFEwf4Tuqdo /bts5K1up7Rwz1KadtjdRxaku63HTPuyIKrzukosoSeZl2Gu/Yh/TfMR/6fWEJiQPq02 ZhstRmQpCYVKVeV5B1ZyRkcU9VUDq7KolXZplRaTpTVr5zx6yhxWylhmoa4iTNcfBnsS Xqi2iVqER8yvsMfmlUsnqZmRxKURuIZyWxbBrigeV80cpNESAW/+IBQS25vifB9ffuV7 4uw2CuV8poR5lTkSwe4Y+qV1fSv6kJmfpGvpDO9ojh/gWQo0pznz3Rq7IQ5RV3n+k18i rslA== X-Received: by 10.194.185.113 with SMTP id fb17mr4167921wjc.29.1389998552076; Fri, 17 Jan 2014 14:42:32 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id po3sm10718325wjc.3.2014.01.17.14.42.30 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 17 Jan 2014 14:42:31 -0800 (PST) Sender: Baptiste Daroussin Date: Fri, 17 Jan 2014 23:42:29 +0100 From: Baptiste Daroussin To: Max Brazhnikov Subject: Re: svn commit: r340118 - head/audio/lame Message-ID: <20140117224229.GA78580@ithaqua.etoilebsd.net> References: <201401172141.s0HLfCP0096620@svn.freebsd.org> <5844234.U6fZ9grvn7@mercury.ph.man.ac.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tThc/1wpZn/ma/RB" Content-Disposition: inline In-Reply-To: <5844234.U6fZ9grvn7@mercury.ph.man.ac.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Alexander Leidinger , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jan 2014 22:42:35 -0000 --tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 17, 2014 at 10:29:57PM +0000, Max Brazhnikov wrote: > On Fri, 17 Jan 2014 21:41:12 +0000Fri Jan 17 21:41:12 2014 Alexander Leid= inger wrote: > > Author: netchild > > Date: Fri Jan 17 21:41:12 2014 > > New Revision: 340118 > > URL: http://svnweb.freebsd.org/changeset/ports/340118 > > QAT: https://qat.redports.org/buildarchive/r340118/ > >=20 > > Log: > > support stagedir > > =20 > > PR: 185565 > > Submitted by: Takefu > >=20 > > Modified: > > head/audio/lame/Makefile > > head/audio/lame/pkg-plist > >=20 > > Modified: head/audio/lame/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/audio/lame/Makefile Fri Jan 17 21:38:50 2014 (r340117) > > +++ head/audio/lame/Makefile Fri Jan 17 21:41:12 2014 (r340118) > > @@ -11,16 +11,14 @@ MAINTAINER=3D netchild@FreeBSD.org > > COMMENT=3D Fast MP3 encoder kit > > =20 > > USES=3D gmake iconv > > -NO_STAGE=3D yes > > USE_AUTOTOOLS=3D libtool > > USE_LDCONFIG=3D yes > > GNU_CONFIGURE=3D yes > > CONFIGURE_ARGS=3D --enable-nasm --enable-mp3rtp --disable-gtktest > > +CONFIGURE_ARGS_PREFIX=3D ${STAGEDIR}${PREFIX} >=20 > What's this?! Does it really do anything? >=20 No it doesn't at all :) btw here is a patch to cleanup a bit that port: http://people.freebsd.org/~bapt/lame.diff it removes the noop "CONFIGURE_ARGS_PREFIX=3D ${STAGEDIR}${PREFIX}" let the standard gmake install install everything, decomposing seems to bri= ng nothing more (no extra files installed or file missing) Strip the binary library (DEVELOPER=3Dyes passes thought stage-qa target wh= ich shows that is it not stripped) Always install the doc in the stage dir and let stage properly decided if it will be install or not. regards, Bapt --tThc/1wpZn/ma/RB Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlLZsdUACgkQ8kTtMUmk6EyIaQCcD91fvN4THKTdV7niCfYzVTfa Yf0AnA/GOjyEihlCJptELLocArh8jEAp =dsBt -----END PGP SIGNATURE----- --tThc/1wpZn/ma/RB--