From owner-freebsd-hackers@freebsd.org Sun Sep 27 13:49:23 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3ADE33FC54F; Sun, 27 Sep 2020 13:49:23 +0000 (UTC) (envelope-from stephen.wall@redcom.com) Received: from GCC02-BL0-obe.outbound.protection.outlook.com (mail-bl0gcc02on20605.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d05::605]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Bzn7k2z1jz3XSk; Sun, 27 Sep 2020 13:49:22 +0000 (UTC) (envelope-from stephen.wall@redcom.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QVcVIAhFo+qBM2N57FPgxK8m5Y2bko3emTEeS37Cq633yyXHk56GzI/7gw6DdjyB5Ske3H4+1CMmK2e5mX3xxCAMtdC9dVWf5GZwp1OhnAjWBqU/Hb1QUuL9Yp7ZRA2q1ZbNfx4/VTHaqttnlkJSiXQqjGAbtTj6+g/pch+hW7M/xlqVMu5lSoSzFHnK8rK2rbcIlpCTlmaqGgQQMa1LiXtVFXpXYn/alViowh/LO7gtw6YOWy7jsaqe8ODc8Pzl+zPw0/u2ra6uZEVVM61HrFNvpmarcTqTDYEauD12KwssKOazvKB9SRNzSvSvc0WboeVYoCvZLbsZNNbgsKGcNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xpR5dSngRQsQdGc8U7L51PpT5ESKqao+XUOk8zpzCsY=; b=i8vlHJdkAL2KCMR+fwabKkieA4FthiY09fNwPxN/Y9qJ3a5bv8f3mcLL3SEGHCIv/N7Gxoh6Lv0vx8OrvwCwp4ha2u/KPXE5HHCqDlPZiAK29Q7cNYLLo7ujJX1QtcoSdxk05PtYj3cVqMwNMnUDYYoTknR+V16q3Q/HwHFXmXIWnWrc89/zkymPIj5Q8B5LjO4BDSIaUQVH7oofCtIqafu7RuFAEyR9WyN0WqCbYigR53Gb4C8lYJaV9viJYtoXDjx0Jbb8ug0082FYuQUz5TDUm8SU9rQ+JE3TjZTYQ4R+cuMoLBledVjjM/2tPBUTiTNbRPSq0i1PyyspA+FluQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=redcom.com; dmarc=pass action=none header.from=redcom.com; dkim=pass header.d=redcom.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redcomlaboratories.onmicrosoft.com; s=selector1-redcomlaboratories-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xpR5dSngRQsQdGc8U7L51PpT5ESKqao+XUOk8zpzCsY=; b=RsdkVKHpPQnr0Xyu3ASokoH9o91wvvzFNNlwhnL/CT346ZKMo/OODw1kBnNEISxaEaOrgl+mua/jIKUPvdRie9ooC4ytHy+9fXITllvdV+BSLpqbNCbrFZvLywBxwm6prlAAbIJSDGIrvAZC36+L4aRlQI+FN1B1kVu4VjJzwdfwN+4QPr0URpeCoA4DM7kdxyobZGpoZGsl4EE/Th9IT/j8/wI8lelqUCTM9rem03v00aSWbusOdy6LslIJTNUObAHsy4b56tpDTf8Ny0fyXRc/ARQONFmBTvg7gdzF3XGWJedelTy25YbWxz+QiZkA59ZK883iP18N2YXSqLjM1g== Received: from MN2PR09MB4876.namprd09.prod.outlook.com (2603:10b6:208:223::18) by BLAPR09MB6785.namprd09.prod.outlook.com (2603:10b6:208:2a7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.20; Sun, 27 Sep 2020 13:49:20 +0000 Received: from MN2PR09MB4876.namprd09.prod.outlook.com ([fe80::4039:3c3b:81b5:cfd8]) by MN2PR09MB4876.namprd09.prod.outlook.com ([fe80::4039:3c3b:81b5:cfd8%6]) with mapi id 15.20.3412.028; Sun, 27 Sep 2020 13:49:19 +0000 From: "Wall, Stephen" To: Rick Macklem , FreeBSD Hackers , "freebsd-current@freebsd.org" Subject: Re: RFC: should copy_file_range(2) remain Linux compatible or support special files? Thread-Topic: RFC: should copy_file_range(2) remain Linux compatible or support special files? Thread-Index: AQHWlFwtm/+ImGEdKkCaptKgpElFK6l7nDvmgAAr7eCAALVoTg== Date: Sun, 27 Sep 2020 13:49:19 +0000 Message-ID: References: , , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [50.48.135.169] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 10c88a65-27da-4dee-29a6-08d862ec2247 x-ms-traffictypediagnostic: BLAPR09MB6785: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nvEPrIu/eQ79xC28pJTS5Swt/mjvJRnhZpchRfcagRi6MSo7zNJVj55meW0oznC8uOsq4s19DLjR4Lv/oyEU/chs5p2BNlyO7GiQ6IVVQqIiQ8vNH9bdFwiB3B8zy6G2jtw0cXNvtuaGPh1gcVi91nGQbD5PBblE4ifDP7MvAY+OhXdzYZGVg0ftT6a+2nFcmyyZTif+SXUVP982EiBY5Xbhu3zMwOdDkkxvbqxsURAOMUDQWrMMFS7+02O02BchjD/DOYrZ32nWr9evoBWk8PUjNp1KgBSB9EKFcEHaw0OOrx/OZIcYGfdypg8hNSqgeO5VWcgtfNfF9aFmwj6b+Hp4rdgLI1b0sqE3ncpZKUdj0l1EmBp0Yd+8nFVGc6Q5 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR09MB4876.namprd09.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(376002)(39830400003)(136003)(396003)(346002)(66446008)(66476007)(52536014)(91956017)(66556008)(7696005)(8676002)(33656002)(5660300002)(2906002)(8936002)(9686003)(478600001)(86362001)(26005)(71200400001)(55016002)(64756008)(186003)(66946007)(76116006)(296002)(110136005)(316002)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: qFX/SimvfzZg43LBda/rtYZenhnAa77a/RZ4Wjop5e0US1bfFL5NsnXSvHFwdMEhNUuey94rhg88jUeoxF5cezJWSwGYlBMmE88+KAyUMt1kugQJsCftBAvLvStFBVhEJ8ZOUZltjTwmq2O44VE+SEJJx05MZIBOzd2g6FkUNw2hM6RYhXNHBYLMoksmESBei/fr+E3sBwTs/HDiVLcucHN/C2c2K7EgvgopYIUb7hJ5HwGE87bVJYo7agAWKN5szOZtzj4eyhqpYplBOoR7RcaqVOALVLc6tD0sYr+cyhqaR//32ZdC5wskD+7oa1uPdzbOJl+itBcmdnzP1OyBpeqCJypdfxFFzSBAfblTuuB4uLXDuAwaHtKoLIT70g3XNliz8OxNY31zC0wHqH5HDAjE6j1XSz9OFA1ZfYIq8y+NGGW2C1rB645zbTgb4r0J2IaTSsxgClfnAUWW6N06xhGfc+lhnXzCNBAhsl7VoWP+Z8htcUE9SoucXRfU5YAVFWSV1kVdjTuNjg2sc9yb/Ex51DkhiqXdo7pBccpdBKn/JvVVHrL3RqcOPD3whghlYy8RKtzOrZGWM8NQxxJvUgIIvOakDz04OsFdphzjIjFSl2fqhIJ/EIpE50jk63QAiwzrRUFNYYxTA3rOr3S2Ng== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: redcom.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR09MB4876.namprd09.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10c88a65-27da-4dee-29a6-08d862ec2247 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2020 13:49:19.7358 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 86200ba5-6348-4d6f-bdd7-96f43e8d9247 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VLzYLQGQn9D+Nl4FTdhNlbDNWsnYAr3ROakF69Mer8CHTFgQgB0TC+9CkkqxOvCfVdFarSN5hdmmJ3GzLW6pEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR09MB6785 X-Rspamd-Queue-Id: 4Bzn7k2z1jz3XSk X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=redcomlaboratories.onmicrosoft.com header.s=selector1-redcomlaboratories-onmicrosoft-com header.b=RsdkVKHp; dmarc=none; spf=pass (mx1.freebsd.org: domain of stephen.wall@redcom.com designates 2a01:111:f400:7d05::605 as permitted sender) smtp.mailfrom=stephen.wall@redcom.com X-Spamd-Result: default: False [-3.15 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.993]; R_DKIM_ALLOW(-0.20)[redcomlaboratories.onmicrosoft.com:s=selector1-redcomlaboratories-onmicrosoft-com]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a01:111:f400::/48]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[redcom.com]; NEURAL_HAM_LONG(-1.02)[-1.021]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[redcomlaboratories.onmicrosoft.com:+]; NEURAL_HAM_SHORT(-0.63)[-0.632]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:8075, ipnet:2a01:111:f000::/36, country:US]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[freebsd-hackers,freebsd-current]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Sep 2020 13:49:23 -0000 =0A= > I'll assume you are referring to the "flags" argument when you say "param= " above.=0A= =0A= Correct, I was misremembering the man page.=0A= =0A= > However, since the Linux man page says it will return EINVAL if=0A= > the "flags" argument is non-zero, you've still introduced an incompatibil= ity=0A= > w.r.t. the Linux behaviour.=0A= =0A= This would be a one-way incompatibility, i.e. code written on linux will ru= n unaltered on FreeBSD.=0A= If the flag were along the lines of `FREEBSD_COPY_DEVICES` (or whatever, im= portant part is `FREEBSD`) it will be quite obvious that this code needs to= be adapted to other platforms:=0A= ```=0A= #ifndef FREEBSD_COPY_DEVICES=0A= #define FREEBSD_COPY_DEVICES 0=0A= #endif=0A= ```=0A= =0A= > Why require extra work for so little purpose?=0A= =0A= I'm sorry, I'm not sure what extra work you are referring to.=A0 Specifying= a flag on copy_file_range(2)?=A0 That's trivial.=0A= =0A= > My opinion is that if we can make it work for character devices, we shoul= d. =0A= =0A= Well, collecting opinions was the point, no? :)=0A= =0A= What's going to use this function besides system commands?=A0 I think I saw= `cp` and `dd` mentioned - I think it unlikely you need to be concerned abo= ut their portability.=0A= =0A= -spw=0A= =0A=