From owner-freebsd-java@FreeBSD.ORG Mon Sep 10 13:14:51 2012 Return-Path: Delivered-To: freebsd-java@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5680D1065688 for ; Mon, 10 Sep 2012 13:14:51 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id ABBE18FC08 for ; Mon, 10 Sep 2012 13:14:48 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA08238 for ; Mon, 10 Sep 2012 16:14:40 +0300 (EEST) (envelope-from avg@FreeBSD.org) Message-ID: <504DE7C0.7050307@FreeBSD.org> Date: Mon, 10 Sep 2012 16:14:40 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:15.0) Gecko/20120830 Thunderbird/15.0 MIME-Version: 1.0 To: freebsd-java@FreeBSD.org References: <4FD61A55.9020906@FreeBSD.org> In-Reply-To: <4FD61A55.9020906@FreeBSD.org> X-Enigmail-Version: 1.4.3 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: Subject: Re: openjdk6: Compiler-gcc.gmk patching vs non-base compiler X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Sep 2012 13:14:51 -0000 on 11/06/2012 19:18 Andriy Gapon said the following: > > patch-set adds blocks of definitions for bsd case to > jdk/make/common/shared/Compiler-gcc.gmk and > corba/make/common/shared/Compiler-gcc.gmk that look like this: > +ifeq ($(PLATFORM), bsd) > + > + # Settings specific to BSD > + CC = $(COMPILER_PATH)gcc > + CPP = $(COMPILER_PATH)gcc -E > + CXX = $(COMPILER_PATH)g++ > ... > > These assignments completely override CC/CXX/etc settings provided via MAKE_ENV. > I think that they should be conditional assignments (?=). > I've already tested such a change and it worked fine for compiling the port with > gcc46. > This is still an issue. -- Andriy Gapon