From nobody Wed May 25 18:11:41 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id DF2521B5FFB9; Wed, 25 May 2022 18:11:43 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L7fKC5wDJz4v2N; Wed, 25 May 2022 18:11:43 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653502303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s+Rahme9z0vZjSGEeJMQgscOqV8sseCp42xHx9nXD9s=; b=Q99hm+Y5HTfYJovpTOlI0o0c6pAMgZfMvusd7G28i2sehGAiAHQslO/oujSUypQIqtbpqz hIxUIaJIFADEr8lNpbMCd99t+OougnsWkFv9GEMf8eQLKrXtb0rto10sfS/qx27a1M5+pc 8vDQiUwbN2WDaouDsmnPQUxzshN/X2YlM0sq7FqUeNgQSTy10EED77G2XlbACccRY8d5pN 7uq8dc/SWRCRV4siJ5vJnoJD8hdkwlPYh5WwQebVA0Qkx+osMfT3lUU09NemhM5yYe9CWh 7tTtpo7C9laHXkzqeBRXbHUvXa7nv+hvabOqfLl/U+izEYp2Auxb/n1F9k+nHQ== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id C7D8AF42C; Wed, 25 May 2022 18:11:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <151c46b1-8939-5739-2967-181912b3e06c@FreeBSD.org> Date: Wed, 25 May 2022 11:11:41 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: git: e605b87a9e75 - main - Save only callee-saved registers in pcb Content-Language: en-US To: Andrew Turner , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202205251038.24PAcmuH042357@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202205251038.24PAcmuH042357@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1653502303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s+Rahme9z0vZjSGEeJMQgscOqV8sseCp42xHx9nXD9s=; b=sVAhOtYk8acbDjyF9tZROjGpkY8lA8ygtO6xmaqhAMwGJzubeOh+ZC9bm7FNijvv0Mi38i pPROPCWUPqZ5jXebFxoar14NGTkCWstBkNXYKNYKMq3ztmQFWDLfLDdgKvPfgSopNUVc1y PdmJvd62hC1cOSFP/nbGBfhZ7gkumULrr8v4J3I3hmZmJX+qTd/WK/vTBNTxnl8vs1MHzb iSldyu47d/QI8ggHF+wmcVB3cv7r5xxDER3W/+8KG+SOVaXaFHB5UrvNLUMufoIyWSRd0P fNPOQdUn2UVlX+vmC43wRimgoSRHnjKM6uyAlq83BpSy2mKV9oZBXrOvTmPQdQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1653502303; a=rsa-sha256; cv=none; b=hvgJzDzuk+haf6ORzopCgh0vOQ0xD/JIfL8jLJV0rxRHINMjG85RkTISsydfw1gJJW2HHp OSBwaFgHdPKhrv8ooHvlJO0l8ug5/4NBE1Jbsrz4wYr9D1k3qt9lEI3lYFmlYBybxph14m HEq3x1UGkpOioU2sY9HE0L4owxTivNSwK0mazisehm4xedKy36EYXJpvnTt0xP9w314j+C VgUOQV83HpxevlueOOfHR+Kt6BiwH9BrPYYt+bFND9PFuJK6gZHzg+XLKAORbiGqyemnQi WRfgJO1CwJX6OuPrH5jscH8eOvLv90zxjdWViqpzga49V4xzWsf6LH1PlxfOsQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 5/25/22 3:38 AM, Andrew Turner wrote: > The branch main has been updated by andrew: > > URL: https://cgit.FreeBSD.org/src/commit/?id=e605b87a9e75a7f693527f0aad8189ae9db20f16 > > commit e605b87a9e75a7f693527f0aad8189ae9db20f16 > Author: Dapeng Gao > AuthorDate: 2022-05-25 10:25:06 +0000 > Commit: Andrew Turner > CommitDate: 2022-05-25 10:26:30 +0000 > > Save only callee-saved registers in pcb > > On AArch64, registers x9-x18 are not callee-saved, yet they are > preserved at many placed in swtch.S. This patch removes code that > preserves these registers. Do you plan to alter the layout of struct pcb? I'll need to make changes to kgdb to not read these registers on newer kernels (and so probably need a __FreeBSD_version bump to cue from, though I can probably just reuse the previous bump). If you are going to alter the layout of struct pcb I'd rather just do one change that handles both than trying to support all three states. -- John Baldwin