From owner-freebsd-pkg@FreeBSD.ORG  Mon May 19 21:51:38 2014
Return-Path: <owner-freebsd-pkg@FreeBSD.ORG>
Delivered-To: freebsd-pkg@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3C01F1E1;
 Mon, 19 May 2014 21:51:38 +0000 (UTC)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
 by mx1.freebsd.org (Postfix) with ESMTP id 287662C12;
 Mon, 19 May 2014 21:51:37 +0000 (UTC)
Received: from AlfredMacbookAir.local (unknown [12.130.117.130])
 by elvis.mu.org (Postfix) with ESMTPSA id 8E3AB1A3C7F;
 Mon, 19 May 2014 14:51:35 -0700 (PDT)
Message-ID: <537A7CD6.9080101@freebsd.org>
Date: Mon, 19 May 2014 17:51:18 -0400
From: Alfred Perlstein <alfred@freebsd.org>
Organization: FreeBSD
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Craig Rodrigues <rodrigc@FreeBSD.org>
Subject: Re: RFC: poudriere in FreeNAS build
References: <CAG=rPVe=wZx=qfj4X49=HMjQaYFZoE0E44Jd52bB1NRkMw_LRg@mail.gmail.com>	<537A700D.8080907@freebsd.org>
 <CAG=rPVfgiJnGhcKajTVSusLWEYcFYLfB1KyPf977-P_m2tfcpg@mail.gmail.com>
In-Reply-To: <CAG=rPVfgiJnGhcKajTVSusLWEYcFYLfB1KyPf977-P_m2tfcpg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Brooks Davis <brooks@freebsd.org>, Warner Losh <imp@bsdimp.com>,
 freebsd-pkg@freebsd.org
X-BeenThere: freebsd-pkg@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Binary package management and package tools discussion
 <freebsd-pkg.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-pkg>,
 <mailto:freebsd-pkg-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pkg/>
List-Post: <mailto:freebsd-pkg@freebsd.org>
List-Help: <mailto:freebsd-pkg-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-pkg>,
 <mailto:freebsd-pkg-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 May 2014 21:51:38 -0000


On 5/19/14, 5:48 PM, Craig Rodrigues wrote:
> On Mon, May 19, 2014 at 1:56 PM, Alfred Perlstein <alfred@freebsd.org> wrote:
>> Craig, this looks really great.
>>
>> Just wondering, does this preserve the these aspects of the build:
>>
>> 1) done in a chroot?
> Poudriere builds things in a jail, which for our purposes is mostly
> similar to a chroot.
> The FreeNAS build system builds the jail first, before invoking
> poudriere to build the ports
> inside the jail.
>
>
>> 2) provides an override for local mirror of source tarballs?
> Yes, we have a variable PORTS_DISTFILES_CACHE which can be overridden
> to point to a directory which contains a local mirror of source tarballs.
> At iXsystems, that directory is an NFS mount which is accessible on
> all build servers.
>
>
>> 3) provides comprehensive logs when a package build fails?
> Poudriere has very extensive and easy to understand logging for each
> package which is built.
>
> --
> Craig

I likely will not have time to test in the coming week or so, however we 
are bringing on another developer that may be able to do so in the next 
few weeks.

That said having watched you put this code into the build AND knowing 
your talent and thoroughness I highly encourage you to commit it as soon 
as you find time.  This will help nanobsd users quite a bit.

-Alfred