From nobody Fri Mar 29 20:56:02 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V5t3m1Pwpz5Fjlf; Fri, 29 Mar 2024 20:56:04 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V5t3m0vNBz4HqY; Fri, 29 Mar 2024 20:56:04 +0000 (UTC) (envelope-from bapt@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711745764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ECWM0WQMtfAnC4/hOVFva7liGRxVaoKNDoStqHjfnns=; b=vg1hzd9zxMYc1G5WYBb2aOWkMrCtKSF4fvkT2n/C62lWIkPuEH21fVKj+nxJM9ofhceUU9 vc0+ugcwYJbl5noCCPMXh2JZeSS4BxhqueaHnLjVPvbgN6IQN3LO+2WtndkFlEvGpIaCRk VPt741snP49OGwBr/kllkNMLRfj3yGQW+xK9K926GO5DN5pulHrCZ5PeA0wr6+ZJRNYfFQ 412Oq5fFRyRpJTho9XpeYTFsIj8Tj0hfRXJhFbiMEuydNwS7vIbKw0FT+TMRKQRRBpUREP dvlHEBZzBAD7s1NQgMw+ihOQKWFUFhEALUip1rVXesDEnFqhnA9p45eMga3q0Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711745764; a=rsa-sha256; cv=none; b=sM0+6gh9lpzN2+k0qC5CvFGAKsDoaYRXJElFjr9bEDCXKrEnoveKE2ERPP0sLXZvPnRN6m eiDgGgSJKirsZR4rUCinYFPW7n8d0fqjNvU+0iZKthcnx3F8IX4d498kyiifyJf3XPiNFH +0Iyqewby+sahdr8Est4BHhQv8Ya5STQ0B3mUVBmA6veUMKJfjLbkuYiyF13VX3evYXj6z CMsb6sgsLUDCInXc1Jwo/J8AQxIMzc4wr4ti458RYOyrAx5J30SMFOCBZInV4YxCrwPB3+ ueXKENUHE3wxwBVMNPxxzxpUA6Lhfu83XCYZL0zQeM1xr63m/MecNT7boC2lSQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711745764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ECWM0WQMtfAnC4/hOVFva7liGRxVaoKNDoStqHjfnns=; b=ExOjSJiXIeZaFMa5JX2rhedhCRTXVzX8kaTPd2nQ+JsKa6gRENXfUu0vuzPdJNiB7DhaI8 cWawsmsOfpURDJRxt5OsIbAlrRkEfvYmfkG9qU6wG7fxj60gfOF+UzGgjIYvkiGBUh4T90 ubuSlcmwiRqCvLN7oCaO2GRFSR6EwUvMrBnROJbf55xm1HiKoiKLszA8MDfyYHejwPvFql AjGcV/IYI6Zcxpbc6sZRj/uwIx2+5sGoZOoddtF/17gy1rHkZjgcYgj/RD99VgVuILbfi0 9ThJ2rSn8Qq9McEOmbPryKJw7mpX5474JfT1tIu8Hlmuza4tVnYAdP1Nyh9M9w== Received: from aniel.nours.eu (nours.eu [176.31.115.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V5t3l6xXfzbwP; Fri, 29 Mar 2024 20:56:03 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id BB0C5180BF2; Fri, 29 Mar 2024 21:56:02 +0100 (CET) Date: Fri, 29 Mar 2024 21:56:02 +0100 From: Baptiste Daroussin To: Yuri Victorovich Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d22f15315b93 - main - devel/gmake43: Corrections Message-ID: References: <202403292007.42TK7lhI072363@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri 29 Mar 21:38, Baptiste Daroussin wrote: > On Fri 29 Mar 20:07, Yuri Victorovich wrote: > > The branch main has been updated by yuri: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=d22f15315b93dcbb96df76f9a4555ff201814fb6 > > > > commit d22f15315b93dcbb96df76f9a4555ff201814fb6 > > Author: Yuri Victorovich > > AuthorDate: 2024-03-29 20:02:40 +0000 > > Commit: Yuri Victorovich > > CommitDate: 2024-03-29 20:02:40 +0000 > > > > devel/gmake43: Corrections > > > > Reported by: Gleb Popov > > --- > > devel/gmake43/Makefile | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/devel/gmake43/Makefile b/devel/gmake43/Makefile > > index f012ce4c0cec..508436255675 100644 > > --- a/devel/gmake43/Makefile > > +++ b/devel/gmake43/Makefile > > @@ -5,10 +5,7 @@ MASTER_SITES= GNU/make > > DISTNAME= make-${PORTVERSION} > > PKGNAMESUFFIX= 43 > > > > -# note: before committing to this port, contact portmgr to arrange for an > > -# experimental ports run. Untested commits may be backed out at portmgr's > > -# discretion. > > -MAINTAINER= tijl@FreeBSD.org > > +MAINTAINER= yuri@FreeBSD.org > > COMMENT= GNU version of 'make' utility > > WWW= https://www.gnu.org/software/make/ > > This is wrong, because it conflicts with the regular gmake if you want to > actually fix the issue of performance you faced, it would have been a good idea > to start a discussion and 1/ the gmake maintainer, 2/ ports community including > portmgr. > > Just speaking on what should be done if we are to revive gmake 4.3 first it > needs to be done in a way which prevent collision with regular gmake: meaning > the binary and all the installation should be in a different path and/or name > than what the gmake provides like naming the binary gmake43. > > Second the framework (Uses/gmake.mk for instance) should grow a new option to > chose gmake43, last it should only be used on ports where the regression has > clearly be characterized. > > that is if we consider it is worth importing, which I don't think it is right > now. > > From what I could read we have a port seems to be abusing gmake and should > probably be fixed to work properly with gmake43, doing this will benefit both > upstream and us, so in my opinion we should not import here gmake43 neither > follow the path I described above, but work with the only port which has an > issue with gmake 4.4+ As I have been told by other this is not explicit enough, an explicit version of this email is: please revert gmake43 addition we are not at a point where it is actually required. Best regards, Bapt