From owner-freebsd-bugs@FreeBSD.ORG  Sun Dec 19 21:20:13 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F014B1065670
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 19 Dec 2010 21:20:12 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id DF4998FC19
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 19 Dec 2010 21:20:12 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oBJLKCmB096379
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 19 Dec 2010 21:20:12 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oBJLKC4A096377;
	Sun, 19 Dec 2010 21:20:12 GMT (envelope-from gnats)
Date: Sun, 19 Dec 2010 21:20:12 GMT
Message-Id: <201012192120.oBJLKC4A096377@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Marcin Cieslak <saper@saper.info>
Cc: 
Subject: Re: bin/138855: [patch] if the hostname is empty, opiepasswd(1)
 creates a seed too short
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Marcin Cieslak <saper@saper.info>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Dec 2010 21:20:13 -0000

The following reply was made to PR bin/138855; it has been noted by GNATS.

From: Marcin Cieslak <saper@saper.info>
To: bug-followup@FreeBSD.org
Cc: deeptech71@gmail.com
Subject: Re: bin/138855: [patch] if the hostname is empty, opiepasswd(1)
 creates a seed too short
Date: Sun, 19 Dec 2010 21:14:36 +0000

 This patch:
 
 Index: newseed.c
 ===================================================================
 --- newseed.c	(revision 212217)
 +++ newseed.c	(working copy)
 @@ -81,6 +81,10 @@
   			utsname.nodename[1] = 'e';
   		}
   		utsname.nodename[2] = 0;
 +		if (!isalnum(utsname.nodename[0])
 +			utsname.nodename[0] = 'k';
 +		if (!isalnum(utsname.nodename[1])
 +			utsname.nodename[1] = 'f';
 
   		if (snprintf(seed, OPIE_SEED_MAX+1, "%s%04d", utsname.nodename,
   				(rand() % 9999) + 1) >= OPIE_SEED_MAX+1)
 
 should fix seed generation also for one-letter hostnames (the
 generated seed for hostname "x" was "x." and the opiepasswd failed
 as well because of the isalnum() check in writerec.c.
 
 //Marcin