From owner-svn-src-projects@freebsd.org Mon May 6 15:27:59 2019 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 03C30158DB41 for ; Mon, 6 May 2019 15:27:59 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6E0257474F for ; Mon, 6 May 2019 15:27:58 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf1-f68.google.com with SMTP id n22so1931605lfe.12 for ; Mon, 06 May 2019 08:27:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:cc; bh=P0Ewzg6C6K6UgPoS2C46UnMdygeVzExGwJPWeZiRnDE=; b=IzAah4HsZxoOBDIODc7+aQV1syjL7pIBujfqZnwrzlycxqEt+lkUIWT8WxRRI8HkYG pOdhMpc2vblduPk73JIXelJjBBtH3ATTxq9OCIaP0e7WUexaY20HMQPMlBGmJ5HzqHvT QrQJFBXoqql1ZzB66awKm85MZIRUQvPBr/dZnWEm5VnAW6LxgVPey529OH0zu2CZUAzY GeIFAQTFtqZ3Hw9rjLVHieH+T4PjVTxXKzgoynHIf8UUGfD8PhzN/ePgbMtSBxPw3Yvb xC/OgkpIOdpRMgZVMRJdwCT0se715V6SKRIQzgUKJ1+qaNwEi9BjD46NKdq9E9OF3yEZ FlHA== X-Gm-Message-State: APjAAAUy1F2/NQ/qLHTGR/XC8AI5Umq50GhbCGDtp+FqFDNV1VT9yERu klqKxxI2yL5pEcspaFXSNUXjElaxSeE27gNJMcwnvLP7 X-Received: by 2002:a19:cc95:: with SMTP id c143mt9741416lfg.138.1557156470774; Mon, 06 May 2019 08:27:50 -0700 (PDT) MIME-Version: 1.0 References: <201905061520.x46FKIUH077726@repo.freebsd.org> In-Reply-To: <201905061520.x46FKIUH077726@repo.freebsd.org> From: Alan Somers Date: Mon, 6 May 2019 09:27:39 -0600 Message-ID: Subject: Re: svn commit: r347184 - projects/fuse2/sys/fs/fuse Cc: src-committers , svn-src-projects@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 6E0257474F X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.86 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.86)[-0.863,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 May 2019 15:27:59 -0000 On Mon, May 6, 2019 at 9:20 AM Alan Somers wrote: > > Author: asomers > Date: Mon May 6 15:20:18 2019 > New Revision: 347184 > URL: https://svnweb.freebsd.org/changeset/base/347184 > > Log: > fusefs: don't allow truncating irregular files on an read-only mount > > The readonly mount check had a special case allowing the sizes of files to > be changed if they weren't regular files. I don't know why. Neither UFS, > ZFS, nor ext2 have such a special case, and I don't know when you would ever > change the size of a non-regular file anyway. > > Sponsored by: The FreeBSD Foundation > > Modified: > projects/fuse2/sys/fs/fuse/fuse_vnops.c Err, this commit was totally wrong. I misread the UFS code. However, I'm not going to revert it because I'm about to rewrite the affected function anyway. -Alan