From owner-svn-src-all@freebsd.org Fri Aug 17 19:16:29 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A5A251078FC6; Fri, 17 Aug 2018 19:16:29 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id ECEA28EEDF; Fri, 17 Aug 2018 19:16:28 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id qkEOfX87mWppDqkEPfJZkL; Fri, 17 Aug 2018 13:16:22 -0600 X-Authority-Analysis: v=2.3 cv=YIcrNiOx c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=dapMudl6Dx4A:10 a=xfDLHkLGAAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=LdYOoKc5PQHeLCZUTHkA:9 a=CjuIK1q_8ugA:10 a=IfaqVvZgccqrtc8gcwf2:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id 1736EC98; Fri, 17 Aug 2018 12:16:50 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w7HJG91b062476; Fri, 17 Aug 2018 12:16:09 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w7HJG9Ba062473; Fri, 17 Aug 2018 12:16:09 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201808171916.w7HJG9Ba062473@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Warner Losh cc: "Conrad E. Meyer" , Cy Schubert , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337936 - in head/sys/contrib/libsodium: . builds builds/msvc builds/msvc/build builds/msvc/properties builds/msvc/vs2010 builds/msvc/vs2010/libsodium builds/msvc/vs2012 builds/msvc/vs2... In-Reply-To: Message from Warner Losh of "Fri, 17 Aug 2018 10:12:30 -0600." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 17 Aug 2018 12:16:09 -0700 X-CMAE-Envelope: MS4wfG/1TEFCDdtv/2/yeHOXKeW/H7caIoRXv8csJ4B1fUFaL5Km0aUfdaMgv6c9k1vVLoVkIlP2UDvnkZxEC/SI5C2r83r/7wMuChGDcadMQBV9hBh5qZGg /0eaC22guY3VRyWKJ5U99aCQt+ImbllLbhgUyxT1YT5KfRBY01ow3Up9BcYM4oVhwdJezgCnMjuvFS10yD3/u71Vy0hJWj5rjG6+F6cNnZMbD6xPKkYDjeoK A+OQCsOWEBkbymc8K0ozZ/yOOWwnmwfhMxADziR6VHMcSrZOWzskvPWeDGXGBZyhdlnnnyUFTicmdNesusmvAlDBt+CFbRjoVKwlhy73KR8= X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Aug 2018 19:16:29 -0000 In message , Warner Losh writes: > --0000000000003c9be50573a3d433 > Content-Type: text/plain; charset="UTF-8" > > On Fri, Aug 17, 2018, 10:05 AM Conrad Meyer wrote: [...] > > >> Bring in libsodium to sys/contrib > > >> ... > > > > > > Why wasn't this imported into vendor-sys first? Especially if we intend > > > on tailoring it over time. > > > > We don't intent on tailoring it at all. > > > > We don't document such an exception... history tells me this belief may be > optimistic.. Agreed, which is why importing into vendor is important. It makes the job of some random committer who's chosen to or been tasked to update it easier. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.