From owner-dev-commits-src-all@freebsd.org Mon Aug 16 16:57:59 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 75E956510BC; Mon, 16 Aug 2021 16:57:59 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4GpL2H0nJ7z4nxx; Mon, 16 Aug 2021 16:57:59 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 17GGvpN1068953 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 16 Aug 2021 19:57:54 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 17GGvpN1068953 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 17GGvp26068952; Mon, 16 Aug 2021 19:57:51 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 16 Aug 2021 19:57:51 +0300 From: Konstantin Belousov To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 8f63fa78e84a - main - rtld: Remove calculate_tls_end Message-ID: References: <202108161056.17GAuFNC017048@gitrepo.freebsd.org> <36c06d31-503b-121b-ca58-ad3f99bda22b@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <36c06d31-503b-121b-ca58-ad3f99bda22b@FreeBSD.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on tom.home X-Rspamd-Queue-Id: 4GpL2H0nJ7z4nxx X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Aug 2021 16:57:59 -0000 On Mon, Aug 16, 2021 at 09:53:35AM -0700, John Baldwin wrote: > On 8/16/21 3:56 AM, Konstantin Belousov wrote: > > The branch main has been updated by kib: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=8f63fa78e84afd23fa68c82eabfe64763c92d4f5 > > > > commit 8f63fa78e84afd23fa68c82eabfe64763c92d4f5 > > Author: Fangrui Song > > AuthorDate: 2021-08-14 17:02:09 +0000 > > Commit: Konstantin Belousov > > CommitDate: 2021-08-16 10:55:35 +0000 > > > > rtld: Remove calculate_tls_end > > Variant I architectures use off and Variant II ones use size + off. > > Define TLS_VARIANT_I/TLS_VARIANT_II symbols similarly to how libc > > handles it. > > Reviewed by: kib > > MFC after: 1 week > > Differential revision: https://reviews.freebsd.org/D31539 > > Differential revision: https://reviews.freebsd.org/D31541 > > Would it make sense to have and move the TLS-related > constants there? Right now we duplicate them in at least two places > (libthr internal headers and libc/rtld). This is some slow progress. Before this commit, we have that in three places. Eventually yes, it should be consolidated.