From owner-freebsd-current@FreeBSD.ORG Wed Aug 14 21:37:09 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 015267D2; Wed, 14 Aug 2013 21:37:09 +0000 (UTC) (envelope-from davide.italiano@gmail.com) Received: from mail-vb0-x230.google.com (mail-vb0-x230.google.com [IPv6:2607:f8b0:400c:c02::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 91C572919; Wed, 14 Aug 2013 21:37:08 +0000 (UTC) Received: by mail-vb0-f48.google.com with SMTP id w16so3118vbf.7 for ; Wed, 14 Aug 2013 14:37:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=jKGgZXo1cl4BhnGPi81iZT82l6KtSMxNd0jU18r02gQ=; b=AlOojpE21tarq98hHkw+f7hRxli4KGVwNJutuJPV2S/lYDcwJIfj7Plgq6NTbXB/PR mL8Ka4lldSsGDvEQovoNCubY1ljF1DR5fUpv6hYgV+vfCJqgh01j3TdMwWf1HVhdqXUd p5J9Res1Z5488nizhbpkkIHLvlZqptca1NBuVtR18jXN/TpRXvaRRcn8LGWfjddTU7W3 GpsIdwQpCRMWuRJPlXQiNwBDyD3IiYdm6wJlz31FwLkCZAEw00AJ0F39sZ8tKKwwntua XxynX8LgEANIpW0vpG5SIgqp7YsmnXwkr1h8Xjp5Y4qzNUqix13FLdmMCczBrUUucny3 Q8bw== MIME-Version: 1.0 X-Received: by 10.52.94.78 with SMTP id da14mr9657951vdb.28.1376516227673; Wed, 14 Aug 2013 14:37:07 -0700 (PDT) Sender: davide.italiano@gmail.com Received: by 10.220.21.140 with HTTP; Wed, 14 Aug 2013 14:37:07 -0700 (PDT) In-Reply-To: References: Date: Wed, 14 Aug 2013 23:37:07 +0200 X-Google-Sender-Auth: nX5-a6T0zX8iCMhDjliPMTPXe7I Message-ID: Subject: Re: patch: enable MEM_LOAD_UOPS_LLC_HIT_RETIRED on sandy bridge xeon From: Davide Italiano To: Adrian Chadd Content-Type: text/plain; charset=ISO-8859-1 Cc: Jim Harris , freebsd-current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2013 21:37:09 -0000 On Wed, Aug 14, 2013 at 10:58 PM, Adrian Chadd wrote: > Hi, > > This (and maybe more?) events are applicable to both the sandy bridge and > sandy bridge xeon CPUs. > > This is from the Intel SDM June 2013 Volume #3. > > David/Jim, does this look fine to you? > > Thanks, > > > ndex: sys/dev/hwpmc/hwpmc_core.c > =================================================================== > --- sys/dev/hwpmc/hwpmc_core.c (revision 254263) > +++ sys/dev/hwpmc/hwpmc_core.c (working copy) > @@ -1541,13 +1541,18 @@ > IAP_F_SBX | IAP_F_IBX | IAP_F_HW), > > IAPDESCR(D2H_01H, 0xD2, 0x01, IAP_F_FM | IAP_F_CA | IAP_F_CC2 | > - IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_IB | IAP_F_IBX | IAP_F_HW), > + IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_SBX | IAP_F_IB | > + IAP_F_IBX | IAP_F_HW), > IAPDESCR(D2H_02H, 0xD2, 0x02, IAP_F_FM | IAP_F_CA | IAP_F_CC2 | > - IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_IB | IAP_F_IBX | IAP_F_HW), > + IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_SBX | IIAP_F_IB | > + IAP_F_IBX | IAP_F_HW), > IAPDESCR(D2H_04H, 0xD2, 0x04, IAP_F_FM | IAP_F_CA | IAP_F_CC2 | > - IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_IB | IAP_F_IBX | IAP_F_HW), > + IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_SBX | IIAP_F_IB | > + IAP_F_IBX | IAP_F_HW), > IAPDESCR(D2H_08H, 0xD2, 0x08, IAP_F_FM | IAP_F_CA | IAP_F_CC2 | > - IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_IB | IAP_F_IBX | IAP_F_HW), > + IAP_F_I7 | IAP_F_WM | IAP_F_SB | IAP_F_SBX | IIAP_F_IB | > + IAP_F_IBX | IAP_F_HW), > + > IAPDESCR(D2H_0FH, 0xD2, 0x0F, IAP_F_FM | IAP_F_CA | IAP_F_CC2 | > IAP_F_I7 | IAP_F_WM), > IAPDESCR(D2H_10H, 0xD2, 0x10, IAP_F_FM | IAP_F_CC2E), > Yes, this looks good for me, but it's incomplete. You need at least to put the event alias for both Sandy Bridge and Sandy Bridge Xeon in sys/dev/hwpmc/pmc_events.h Also, you tested the aforementioned events one by one to see if the pmc is allocated etc...? Thanks, -- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare