From owner-svn-ports-head@FreeBSD.ORG Sat Mar 28 21:09:37 2015 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E1BD11A4 for ; Sat, 28 Mar 2015 21:09:36 +0000 (UTC) Received: from mail-wi0-x235.google.com (mail-wi0-x235.google.com [IPv6:2a00:1450:400c:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5B1F296F for ; Sat, 28 Mar 2015 21:09:36 +0000 (UTC) Received: by wibgn9 with SMTP id gn9so74990566wib.1 for ; Sat, 28 Mar 2015 14:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=38zKaA7bcNS5gLiwkocU/fFLwId2rceXJgaqH1rNNaw=; b=X6U78wuhRE4DFfblAQ7+hqEyHVsVbS6a/f49MLXim8yy+bK1NmIkZwe3Qexfs3fCEr j0iuQknd6JeAnD7vI8ukYDeB26cs1yQSnBsZtlvExNGJyRhkQSAGQo4ceJrFZChu4lL6 hSHNreP85l20gFaSG/3TngBd8UQbWmlgnIdHU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=38zKaA7bcNS5gLiwkocU/fFLwId2rceXJgaqH1rNNaw=; b=EnvSc39hmP8aA+xIqYqu9NVG7Rwdl9/4HqMUEOVeVig1ng1wagl5+hYkPDOvzlcKm5 fkgJHJIuEvEC9diTh3LTTzjzLlKitKSugv/fjbO/lPRbvEnp4Duj9j+DNKsFSgCSBRpv 1OtgrxTbgOBNRXsfVJUZlYLjYYqovzd8g2VmHsEdD+v4V7Rrn2TUDJ+/7zfW+iEJIw22 sKdNp0EpIXRtdf50t1x0+mogoaZHL/M6TH4pk/zZkI2Sy5JV5/OyxD06uGEc0r9V9bDl eSesBnAW0Tb4Xd3s5rNQAYL4n2GW0yZpJZWF97X8od/wOtYZJb+pQ3Ta3nqBe1AD99J/ J/Vg== X-Gm-Message-State: ALoCoQl+UZWoj85OiFCMk/ar2dHgjrIK//j6zUWyjYKn8KNEoAXgQXixNGj07q31fkmoztluA0Ed X-Received: by 10.180.98.137 with SMTP id ei9mr8346354wib.92.1427576973517; Sat, 28 Mar 2015 14:09:33 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.28.211.135 with HTTP; Sat, 28 Mar 2015 14:09:03 -0700 (PDT) In-Reply-To: <5516CEB9.3090600@FreeBSD.org> References: <201503281450.t2SEoNmd076083@svn.freebsd.org> <5516CEB9.3090600@FreeBSD.org> From: Eitan Adler Date: Sat, 28 Mar 2015 14:09:03 -0700 X-Google-Sender-Auth: dajDDOqXt2CbLjQWPK-4UOZhoBo Message-ID: Subject: Re: svn commit: r382492 - head/Mk/Uses To: Bryan Drewery Content-Type: text/plain; charset=UTF-8 Cc: "svn-ports-head@freebsd.org" , Baptiste Daroussin , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2015 21:09:37 -0000 On 28 March 2015 at 08:54, Bryan Drewery wrote: > On 3/28/2015 9:50 AM, Baptiste Daroussin wrote: >> Author: bapt >> Date: Sat Mar 28 14:50:22 2015 >> New Revision: 382492 >> URL: https://svnweb.freebsd.org/changeset/ports/382492 >> QAT: https://qat.redports.org/buildarchive/r382492/ >> >> Log: >> Add USES=metaport to simplify writing metaports >> >> Added: >> head/Mk/Uses/metaport.mk (contents, props changed) >> >> Added: head/Mk/Uses/metaport.mk >> ============================================================================== >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >> +++ head/Mk/Uses/metaport.mk Sat Mar 28 14:50:22 2015 (r382492) >> @@ -0,0 +1,20 @@ >> +# $FreeBSD$ >> +# >> +# Sets the default variables to handle metaports >> +# >> +# Feature: metaport >> +# Usage: USES=metaport >> +# >> +# Take no arguments >> + >> +.if !defined(_INCLUDE_USES_METAPORT_MK) >> +_INCLUDE_USES_METAPORT_MK= yes >> + >> +MASTER_SITES= # >> +DISTFILES= # >> +EXTRACT_ONLY= # >> +NO_BUILD= yes >> +NO_INSTALL= yes >> +NO_MTREE= yes >> + >> +.endif >> > > Now that I quickly flew past this, I think these should all be ?=. I've > had to make meta ports at work that did include 1 few files. I know they > are not quite technically "meta packages" at that point but IMHO they > still qualify. I'm not strong on this opinion though. -1 on making them ?=. IMHO a 'metaport' should be a strong abstraction, not just set a set of defaults. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams